Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VI-957] Add MHVUserAccountPolicy #20163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[VI-957] Add MHVUserAccountPolicy #20163

wants to merge 1 commit into from

Conversation

rileyanderson
Copy link
Contributor

Summary

  • Add policy to check if user can create a MhvUserAccount

Related issue(s)

Testing

  • Test/v0/user/mhv_user_account with loa1 user
    • You should get a 403
  • Test/v0/user/mhv_user_account with loa3 user
    • You should get a 200

What areas of the site does it impact?

MHV User Accounts

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

Copy link

github-actions bot commented Jan 8, 2025

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/policies/mhv_user_account_policy.rb

Copy link
Contributor

@bramleyjl bramleyjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logged in with an LOA1 user and received a 403 when requesting v0/user/mhv_user_account. Repeated the auth with an LOA3 user and got a 200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants