API-43677-remove-refactored-local-bgs-files

[stiehlrod]

Summary

• Removes local_bgs_refactored & local_bgs_proxy and their tests.
  4 files changed, 340 deletions(-)

Related issue(s)

• API-43677

Testing done

• v1 526
• v2 526 sync
• v2 itf
• v2 POA submit 2122a
• v2 POA validate 2122
• v1 claims show
• v2 claims index
• v1 5103

What areas of the site does it impact?

deleted:    modules/claims_api/lib/bgs_service/local_bgs_proxy.rb
modified:   modules/claims_api/lib/bgs_service/local_bgs_refactored.rb
deleted:    modules/claims_api/spec/lib/claims_api/local_bgs_proxy_spec.rb
deleted:    modules/claims_api/spec/lib/claims_api/local_bgs_refactored_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 225 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/lib/bgs_service/local_bgs_proxy.rb (+0/-42) modules/claims_api/lib/bgs_service/local_bgs_refactored.rb (+0/-40) modules/claims_api/spec/lib/claims_api/local_bgs_proxy_spec.rb (+0/-68) modules/claims_api/spec/lib/claims_api/local_bgs_refactored_spec.rb (+0/-75) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[rockwellwindsor-va]

@stiehlrod Looks like an unrelated test is failing, everything related to this looked good to me.

[FonzMP]

[FonzMP]