Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

93461: Add stamps and digital signature to VBA214140 #20059

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

derekhouck
Copy link
Contributor

@derekhouck derekhouck commented Dec 31, 2024

Summary

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Unit tests for all new instance methods
  • Added 21-4140 to the specs for scrubbing PII in the event of a failure

What areas of the site does it impact?

At the moment, none. It will ultimately impact the Simple Forms API, adding support for the 21-4140 form.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@derekhouck derekhouck force-pushed the 93461-model-for-employment-history-questionnaire branch from 4303155 to d10cba9 Compare December 31, 2024 17:32
@va-vfs-bot va-vfs-bot temporarily deployed to 93461-model-for-employment-history-questionnaire/main/main December 31, 2024 17:32 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 93461-model-for-employment-history-questionnaire/main/main December 31, 2024 17:50 Inactive
@derekhouck derekhouck force-pushed the 93461-model-for-employment-history-questionnaire branch from 62da98b to 067589e Compare January 7, 2025 16:37
@va-vfs-bot va-vfs-bot temporarily deployed to 93461-model-for-employment-history-questionnaire/main/main January 7, 2025 17:17 Inactive
@derekhouck derekhouck force-pushed the 93461-model-for-employment-history-questionnaire branch from 067589e to f331794 Compare January 8, 2025 15:41
@va-vfs-bot va-vfs-bot temporarily deployed to 93461-model-for-employment-history-questionnaire/main/main January 8, 2025 16:15 Inactive
@derekhouck derekhouck force-pushed the 93461-model-for-employment-history-questionnaire branch from f331794 to 927cf6e Compare January 9, 2025 16:31
@va-vfs-bot va-vfs-bot temporarily deployed to 93461-model-for-employment-history-questionnaire/main/main January 9, 2025 16:50 Inactive
@derekhouck derekhouck force-pushed the 93461-model-for-employment-history-questionnaire branch from 927cf6e to c6e48de Compare January 10, 2025 16:04
@va-vfs-bot va-vfs-bot temporarily deployed to 93461-model-for-employment-history-questionnaire/main/main January 10, 2025 16:19 Inactive
@derekhouck derekhouck force-pushed the 93461-model-for-employment-history-questionnaire branch from c6e48de to 5e3dc5e Compare January 14, 2025 15:54
@va-vfs-bot va-vfs-bot temporarily deployed to 93461-model-for-employment-history-questionnaire/main/main January 14, 2025 15:55 Inactive
Comment on lines +25 to +26
coords = employed? ? [[50, 410]] : [[50, 275]]
[{ coords:, text: signature, page: 1 }]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coordinates originate from the bottom left corner of the page.

@derekhouck derekhouck requested a review from ryguyk January 14, 2025 16:32
@derekhouck derekhouck marked this pull request as ready for review January 14, 2025 16:32
@derekhouck derekhouck requested review from a team as code owners January 14, 2025 16:32
ryguyk
ryguyk previously approved these changes Jan 15, 2025
Copy link
Contributor

@ryguyk ryguyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this last piece of the puzzle get completed.

before do
sign_in
post '/simple_forms_api/v1/simple_forms', params: data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The post should be in the examples (it)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand a little bit on the reason why? Is there a technical RSpec problem with the post request being in a before block, or is it an human-centered organizational/comprehension issue?

@va-vfs-bot va-vfs-bot temporarily deployed to 93461-model-for-employment-history-questionnaire/main/main January 21, 2025 18:16 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create model class for Employment-History questionnaire
4 participants