-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
93461: Add stamps and digital signature to VBA214140 #20059
base: master
Are you sure you want to change the base?
93461: Add stamps and digital signature to VBA214140 #20059
Conversation
4303155
to
d10cba9
Compare
62da98b
to
067589e
Compare
067589e
to
f331794
Compare
f331794
to
927cf6e
Compare
927cf6e
to
c6e48de
Compare
This reverts commit d10cba9.
c6e48de
to
5e3dc5e
Compare
coords = employed? ? [[50, 410]] : [[50, 275]] | ||
[{ coords:, text: signature, page: 1 }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coordinates originate from the bottom left corner of the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see this last piece of the puzzle get completed.
before do | ||
sign_in | ||
post '/simple_forms_api/v1/simple_forms', params: data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The post
should be in the examples (it
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you expand a little bit on the reason why? Is there a technical RSpec problem with the post request being in a before
block, or is it an human-centered organizational/comprehension issue?
Summary
VBA214140
.Related issue(s)
Testing done
What areas of the site does it impact?
At the moment, none. It will ultimately impact the Simple Forms API, adding support for the 21-4140 form.
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?