vebt-830 code tims fix and tests

[nfstern02]

Summary

• This work is behind a feature toggle (flipper): NO
• Refined criteria for processing TIMS ingest errors
• Not sure if this would be classified as a bug so much as incorrect criteria?
• Removed logic that incorrectly checked for a conflict and changed logic for loading user profile
• vebt
• N/A

Related issue(s)

• Jira ticket attached in word document

Testing done

• [x ] New code is covered by unit tests
• Describe what the old behavior was prior to the change
  TIMS ingest records were incorrectly being identified as having errors when they should not have.
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  Run a TIMS ingest job (LoadData rake task) and confirm errors are not being flagged that shouldn't be. These will be logged.
  Run RSpec tests

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)

VEBT-830.docx

[github-actions]

1 Warning

⚠️

This PR changes 313 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/vye/app/models/vye/user_profile.rb (+1/-7) modules/vye/lib/vye/load_data.rb (+69/-35) modules/vye/spec/lib/vye/load_data_spec.rb (+143/-0) modules/vye/spec/models/vye/user_profile_spec.rb (+4/-54) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger