Vebt 747 additional logging - Vye Midnight Run & Sundown Sweep

[nfstern02]

Summary

• *This work is behind a feature toggle (flipper): NO
• Added more logging statements to Vye Midnight Run & Sundown Sweep. Included RSpec tests for same.
• N/A
• Additional logging statements to assist in troubleshooting production issues
• vebt
• N/A

Related issue(s)

• Ticket attached in word document
• N/A
• N/A

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
  Minimal logging statements. More statements now
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  Ran mocks in sandbox. RSpec tests

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)
VYE Nightly Sundown Sweep and Midnite Run batch jobs.

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)

VEBT-747.doc.docx

[github-actions]

1 Warning

⚠️

This PR changes 219 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/vye/app/sidekiq/vye/midnight_run.rb (+29/-0) modules/vye/app/sidekiq/vye/midnight_run/ingress_bdn.rb (+5/-2) modules/vye/app/sidekiq/vye/midnight_run/ingress_bdn_chunk.rb (+0/-0) modules/vye/app/sidekiq/vye/sundown_sweep.rb (+2/-0) modules/vye/app/sidekiq/vye/sundown_sweep/clear_deactivated_bdns.rb (+2/-2) modules/vye/app/sidekiq/vye/sundown_sweep/delete_processed_s3_files.rb (+2/-2) modules/vye/lib/concerns/vye/cloud_transfer.rb (+42/-3) modules/vye/lib/tasks/vye/setup_for_sundown_sweep_devtest.rake (+37/-0) modules/vye/lib/vye/batch_transfer/bdn_chunk.rb (+2/-0) modules/vye/lib/vye/batch_transfer/chunk.rb (+9/-0) modules/vye/lib/vye/batch_transfer/chunking.rb (+7/-0) modules/vye/spec/lib/vye/batch_transfer/bdn_chunk_spec.rb (+16/-3) modules/vye/spec/lib/vye/batch_transfer/chunk_spec.rb (+30/-0) modules/vye/spec/sidekiq/vye/midnight_run/ingress_bdn_spec.rb (+14/-0) modules/vye/spec/sidekiq/vye/midnight_run_spec.rb (+10/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger