Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6: [ART] Skip spec for POA request accredited entities migration #20000

Conversation

nihil2501
Copy link
Contributor

No description provided.

Copy link

2 Errors
🚫 This PR changes 1133 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • db/schema.rb (+9/-6)

  • modules/accredited_representative_portal/app/controllers/accredited_representative_portal/v0/power_of_attorney_requests_controller.rb (+8/-41)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb (+294/-4)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request.rb (+18/-1)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request_decision.rb (+4/-1)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request_expiration.rb (+0/-1)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request_resolution.rb (+0/-6)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/application_serializer.rb (+18/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_decision_serializer.rb (+19/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_expiration_serializer.rb (+5/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_resolution_serializer.rb (+5/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer.rb (+21/-0)

  • modules/accredited_representative_portal/bin/rails (+5/-3)

  • modules/accredited_representative_portal/db/migrate/20241223094500_make_poa_request_and_form_adjustments.rb (+18/-0)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_decision.rb (+0/-8)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_form.rb (+53/-6)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request.rb (+10/-2)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request_decision.rb (+12/-0)

  • modules/accredited_representative_portal/spec/factories/{power_of_attorney_expiration.rb => power_of_attorney_request_expiration.rb} (+1/-3)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request_resolution.rb (+8/-29)

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_form_spec.rb (+0/-12)

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_decision_spec.rb (+0/-7)

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_expiration_spec.rb (+0/-12)

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_resolution_spec.rb (+0/-118)

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_spec.rb (+0/-8)

  • modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb (+331/-26)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

🚫

Modified files in db/migrate or db/schema.rb changes should be the only files checked into this PR.

File Summary

DB File(s)

  • db/schema.rb

  • modules/accredited_representative_portal/db/migrate/20241223094500_make_poa_request_and_form_adjustments.rb

    App File(s)

    • modules/accredited_representative_portal/app/controllers/accredited_representative_portal/v0/power_of_attorney_requests_controller.rb
  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request.rb

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request_decision.rb

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request_expiration.rb

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request_resolution.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/application_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_decision_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_expiration_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_resolution_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer.rb

  • modules/accredited_representative_portal/bin/rails

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_decision.rb

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_form.rb

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request.rb

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request_decision.rb

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request_expiration.rb

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request_resolution.rb

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_form_spec.rb

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_decision_spec.rb

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_expiration_spec.rb

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_resolution_spec.rb

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_spec.rb

  • modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb

Application code must always be backwards compatible with the DB,
both before and after migrations have been run. For more info:

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/accredited-entities-migration.1/main/main December 23, 2024 13:35 Inactive
@nihil2501 nihil2501 force-pushed the art/poa-requests/part-4/form-data branch from 8fdb669 to bfe70f6 Compare December 23, 2024 14:22
@nihil2501 nihil2501 closed this Dec 23, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/accredited-entities-migration.1/main/main December 23, 2024 14:25 Inactive
@ojbucao ojbucao reopened this Dec 27, 2024
@ojbucao ojbucao closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants