Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5: [ART] Serialize POA form data with POA request #19998

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

nihil2501
Copy link
Contributor

@nihil2501 nihil2501 commented Dec 23, 2024

Description

Refactors the PowerOfAttorneyForm and Serializers
Unskips the temporarily skipped specs from previous PR

Copy link

github-actions bot commented Dec 23, 2024

1 Error
🚫 This PR changes 563 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb (+33/-5)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request.rb (+15/-1)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/application_serializer.rb (+18/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_decision_serializer.rb (+0/-18)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_expiration_serializer.rb (+0/-4)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_resolution_serializer.rb (+0/-6)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer.rb (+10/-6)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/decision_serializer.rb (+21/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/expiration_serializer.rb (+7/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/resolution_serializer.rb (+7/-0)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_form.rb (+51/-4)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request.rb (+1/-0)

  • modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb (+290/-66)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main December 23, 2024 12:01 Inactive
@nihil2501 nihil2501 changed the title [ART] Serialize POA form data with POA request 5: [ART] Serialize POA form data with POA request Dec 23, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main December 23, 2024 12:22 Inactive
@nihil2501 nihil2501 force-pushed the art/poa-requests/part-4/form-data branch from fa65903 to 8fdb669 Compare December 23, 2024 12:37
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main December 23, 2024 12:38 Inactive
@nihil2501 nihil2501 force-pushed the art/poa-requests/part-4/form-data branch from 8fdb669 to bfe70f6 Compare December 23, 2024 14:22
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main December 23, 2024 14:24 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main December 26, 2024 22:46 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-3/migrations.2 branch 2 times, most recently from 4583dd1 to 51a6985 Compare December 26, 2024 23:28
@ojbucao ojbucao force-pushed the art/poa-requests/part-4/form-data branch from 3b42013 to bffe866 Compare December 26, 2024 23:38
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main December 26, 2024 23:40 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main December 27, 2024 00:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/representatives/main/main December 27, 2024 00:15 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-3/migrations.2 branch from 51a6985 to d25e8f0 Compare December 27, 2024 04:08
@ojbucao ojbucao force-pushed the art/poa-requests/part-4/form-data branch from a92c469 to bfe70f6 Compare December 27, 2024 04:09
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main December 27, 2024 04:10 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-3/migrations.2 branch from d25e8f0 to 9ead4aa Compare December 27, 2024 07:05
@ojbucao ojbucao force-pushed the art/poa-requests/part-4/form-data branch from bfe70f6 to 2989398 Compare December 27, 2024 07:15
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main December 27, 2024 07:16 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-4/form-data branch from 3c61cf1 to cb9aa03 Compare January 9, 2025 16:10
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main January 9, 2025 16:20 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-4/form-data branch 2 times, most recently from 4d6f7ff to 1649199 Compare January 9, 2025 16:36
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main January 9, 2025 16:49 Inactive
@ojbucao ojbucao self-requested a review January 9, 2025 16:50
@ojbucao ojbucao requested a review from a team January 9, 2025 16:50
@ojbucao ojbucao force-pushed the art/poa-requests/part-4/form-data branch from 1649199 to a9143f5 Compare January 9, 2025 16:57
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-4/form-data/main/main January 9, 2025 17:29 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-4/form-data branch from a9143f5 to 187e304 Compare January 9, 2025 17:34
@ojbucao ojbucao force-pushed the art/poa-requests/part-4/form-data branch from 187e304 to 92cd054 Compare January 9, 2025 18:19
@LindseySaari LindseySaari merged commit 59836fd into master Jan 9, 2025
20 of 21 checks passed
@LindseySaari LindseySaari deleted the art/poa-requests/part-4/form-data branch January 9, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants