Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Art/98710/poa requests #19993

Open
wants to merge 5 commits into
base: remove-mock-kms-keys
Choose a base branch
from
Open

Art/98710/poa requests #19993

wants to merge 5 commits into from

Conversation

nihil2501
Copy link
Contributor

No description provided.

ojbucao and others added 5 commits December 20, 2024 20:35
@ojbucao @nihil2501
Add PowerOfAttorneyRequestSerializer and accompanying spec
1999e55 
- Implement PowerOfAttorneyRequestSerializer to handle resolution attributes:
  - Includes `id`, `type`, `created_at`, `reason`, and conditional `creator_id`
- Ensure safe handling of nil values with safe navigation (`&.`) and `try`
- Add RSpec tests to validate:
  - Resolution serialization for decisions, expirations, and declinations
  - Handling of `reason` and `creator_id` conditionally
  - Nil resolution scenarios
@ojbucao @nihil2501
Add serializer for PowerOfAttorneyRequest with controller and tests
8d0a081 
- Implement `PowerOfAttorneyRequestSerializer` to standardize JSON:API output
- Add request specs for controller endpoints (`index` and `show`)
- Add serializer specs to ensure proper formatting of resolution details
- Normalize response keys for consistency in test expectations
@ojbucao @nihil2501
(feat): Add serializers for PowerOfAttorneyRequest and Resolution wit…
c6e4481 
…h specs

- Implement `PowerOfAttorneyRequestSerializer` to handle serialization of power of attorney requests, including nested resolution data.
- Implement `PowerOfAttorneyRequestResolutionSerializer` to serialize resolution details, accommodating various resolution subtypes.
- Add comprehensive specs for both serializers to ensure accurate and dynamic handling of attributes.
- Adjust model factories accordingly
@ojbucao @nihil2501
(fix) Refactor AR PowerOfAttorneyRequestController includes for impro…
ce1dea1 
…ved query performance

- Updated `includes` to reference `resolving` instead of just `resolution`
- Added a limit of 100 records in the `index` action to optimize data retrieval
@nihil2501
[ART-98710] Spike ARP POA request list and show endpoints
df700fc
@nihil2501 nihil2501 requested review from a team as code owners December 21, 2024 06:02
@va-vfs-bot va-vfs-bot temporarily deployed to art/98710/poa-requests/main/main December 21, 2024 06:02 Inactive
@github-actions GitHub Actions
Copy link

1 Warning
⚠️ This PR changes 495 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/accredited_representative_portal/app/controllers/accredited_representative_portal/v0/power_of_attorney_requests_controller.rb (+8/-41)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request_decision.rb (+4/-1)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request_expiration.rb (+0/-1)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request_resolution.rb (+0/-6)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_decision_serializer.rb (+18/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_expiration_serializer.rb (+4/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_resolution_serializer.rb (+6/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer.rb (+14/-0)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_decision.rb (+0/-8)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_form.rb (+0/-2)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request.rb (+9/-2)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request_decision.rb (+12/-0)

  • modules/accredited_representative_portal/spec/factories/{power_of_attorney_expiration.rb => power_of_attorney_request_expiration.rb} (+1/-3)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request_resolution.rb (+8/-29)

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_form_spec.rb (+0/-12)

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_decision_spec.rb (+0/-7)

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_expiration_spec.rb (+0/-12)

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_resolution_spec.rb (+0/-118)

  • modules/accredited_representative_portal/spec/models/accredited_representative_portal/power_of_attorney_request_spec.rb (+0/-8)

  • modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb (+135/-26)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@github-actions GitHub Actions
Copy link

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:

@github-actions GitHub Actions
Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ojbucao ojbucao

Labels
codeowners-addition-failure codeowners-delete-failure require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nihil2501 @ojbucao @va-vfs-bot