Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 42973 fixing status ids #19992

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

michaelhobson
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): NO
  • Updating the Forms, Decision Reviews v1, and Benefits Intake API catalog-info yaml files in support of CodeVA (fixing status monitors, adding release notes)
  • N/A
  • N/A
  • BananaPeels (I'm the PM)
  • N/A

Related issue(s)

Testing done

  • N/A
  • N/A
  • N/A
  • N/A
    • N/A
    • N/A

Screenshots

Note: Optional

What areas of the site does it impact?

CodeVA

Acceptance criteria

  • [N/A] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • [N/A] Events are being sent to the appropriate logging solution
  • [N/A] Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • [N/A] Feature/bug has a monitor built into Datadog (if applicable)
  • [N/A] If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • [N/A] I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants