Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vebt 558 tests #19986

Merged
merged 27 commits into from
Dec 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8d049a7
Create boilerplate for 10282 form
alexchan-va Nov 13, 2024
8b6c175
Merge branch 'vebt-781' of https://github.com/department-of-veterans-…
alexchan-va Nov 22, 2024
d93b1ec
Add 10282 form to save to db
alexchan-va Dec 5, 2024
f1640ac
Make new Create Daily Excel Files for 10282 form
alexchan-va Dec 5, 2024
a041aba
Write to CSV instead of XLSX
alexchan-va Dec 6, 2024
7ce4ff0
Add logic to not repeat processed submissions
alexchan-va Dec 6, 2024
b3271e2
Fix lint errors
alexchan-va Dec 6, 2024
23ee7a1
Fix linting errors
alexchan-va Dec 9, 2024
a1d8b3b
Add mailer functionality for generated excel file
alexchan-va Dec 13, 2024
6217542
Add VANotify email to 10282
alexchan-va Dec 13, 2024
c967e30
Add back in line removed for testing
alexchan-va Dec 13, 2024
40bf897
Fix linter
alexchan-va Dec 13, 2024
8f2ef3f
Merge branch 'vebt-555' into vebt-731
alexchan-va Dec 13, 2024
3df8d05
Add 10282 Form specs
alexchan-va Dec 13, 2024
87b665f
Add excel file event tests
alexchan-va Dec 16, 2024
53fce20
Add remainder of 10282 test
alexchan-va Dec 17, 2024
0a16b3f
Clean up linting and naming
alexchan-va Dec 17, 2024
c0f35bf
Reformat mailer classes for 10282
alexchan-va Dec 18, 2024
44e4c2f
Modify tests to reduce redundancy
alexchan-va Dec 19, 2024
12103fc
Merge branch 'master' into vebt-558
alexchan-va Dec 19, 2024
3733d7e
Remove migration from PR
alexchan-va Dec 19, 2024
6e7e6a4
Remove schema changes from this PR
alexchan-va Dec 19, 2024
00fcc82
Merge branch 'master' into vebt-558-tests
alexchan-va Dec 26, 2024
6f70c5b
Update create_excel_files_mailer.rb to remove white space
alexchan-va Dec 26, 2024
09128bb
Fix tests and lint failures
alexchan-va Dec 26, 2024
95964c1
Fix linter
alexchan-va Dec 26, 2024
a6b8e5f
Remove 10282 from ytd reports
alexchan-va Dec 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -1360,6 +1360,7 @@ spec/sidekiq/copay_notifications @department-of-veterans-affairs/vsa-debt-resolu
spec/sidekiq/decision_review @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/sidekiq/education_form @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/sidekiq/education_form/create_daily_spool_files.rb @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/govcio-vfep-codereviewers
spec/sidekiq/education_form/create_daily_excel_files_spec.rb @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/sidekiq/delete_old_pii_logs_job_spec.rb @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/va-api-engineers
spec/sidekiq/evss/dependents_application_job_spec.rb @department-of-veterans-affairs/benefits-dependents-management @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/sidekiq/evss/disability_compensation_form @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
Expand Down Expand Up @@ -1559,6 +1560,7 @@ spec/lib/zero_silent_failures @department-of-veterans-affairs/va-api-engineers @
spec/mailers/ch31_submissions_report_mailer_spec.rb @department-of-veterans-affairs/benefits-non-disability @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/mailers/create_daily_spool_files_mailer_spec.rb @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/mailers/create_staging_spool_files_mailer_spec.rb @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/mailers/create_excel_files_mailer_spec.rb @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/mailers/dependents_application_failure_mailer_spec.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/mailers/direct_deposit_mailer_spec.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/mailers/previews/appeals_api_daily_error_report_mailer_preview.rb @department-of-veterans-affairs/lighthouse-banana-peels @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class CreateDailyFiscalYearToDateReport
daily_processed: 0
}.freeze

FORM_TYPES = EducationBenefitsClaim::FORM_TYPES
FORM_TYPES = EducationBenefitsClaim::FORM_TYPES.reject { |form_type| form_type == '10282' }

FORM_TYPE_HEADERS = EducationBenefitsClaim.form_headers(FORM_TYPES).map do |form_header|
[form_header, '', '']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class CreateDailyYearToDateReport
daily_processed: 0
}.freeze

FORM_TYPES = EducationBenefitsClaim::FORM_TYPES
FORM_TYPES = EducationBenefitsClaim::FORM_TYPES.reject { |form_type| form_type == '10282' }

FORM_TYPE_HEADERS = EducationBenefitsClaim.form_headers(FORM_TYPES).map do |form_header|
[form_header, '', '']
Expand Down
Loading
Loading