Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mocked encrypted_kms_key from AccreditedRepresentativePortal POA Request Factories #19983

Conversation

ojbucao
Copy link
Contributor

@ojbucao ojbucao commented Dec 20, 2024

Remove mocked encrypted_kms_key from the following AccreditedRepresentativePortal POA Request Factories:
PowerOfAttorneyForm
PowerOfAttorneyRequestResolution

@ojbucao ojbucao changed the base branch from master to remove-kms-null-constraints December 20, 2024 19:26
Copy link

1 Error
🚫

Modified files in db/migrate or db/schema.rb changes should be the only files checked into this PR.

File Summary

DB File(s)

  • db/schema.rb

  • modules/accredited_representative_portal/db/migrate/20241220164524_remove_null_constraint_from_encrypted_kms_key_in_ar_power_of_attorney_forms.rb

  • modules/accredited_representative_portal/db/migrate/20241220164548_remove_null_constraint_from_encrypted_kms_key_in_ar_power_of_attorney_request_resolutions.rb

    App File(s)

    • modules/accredited_representative_portal/spec/factories/power_of_attorney_form.rb
  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request_resolution.rb

Application code must always be backwards compatible with the DB,
both before and after migrations have been run. For more info:

Generated by 🚫 Danger

@ojbucao ojbucao changed the base branch from remove-kms-null-constraints to master December 20, 2024 19:28
stevenjcumming and others added 6 commits December 20, 2024 11:29
…age (#19937)

* Duplicate factory updates for local testing

* Merge PDFs with hexapdf

* Only merge PDFs if necessary

* Stop adding next steps pages

* Regenerate PDF fixtures without next steps pages
* Created get_facilities_mock_data.json and update static_data.json

- get_facilties_mock_data.json is a list of PATSR approved health facilities
- static_data.json is now up to data with the most recent addition from CRM API

* Fix bug in InquiryDetails and update spec

- inquiry_details now handles `it's a general question` correctly

* Created FacilitiesDataJob

- Job will run every 24hours to cache the data

* Update HealthFacilities#search

- search now will filter and allow only patsr approved facilities
* Duplicate main form endpoints
- also contestable issues endpoints
-v1 and v2

* Fix linting errors

* Duplicate final endpoints
- evidence
- notification callbacks

* Fix shared example constant collision

* 98361: Update DR engine controllers to use engine jobs

---------

Co-authored-by: Molly Trombley-McCann <[email protected]>
@ojbucao ojbucao force-pushed the remove-kms-key-null-constraints-models branch from 090b112 to 70cb036 Compare December 20, 2024 19:29
@ojbucao ojbucao changed the base branch from master to remove-kms-null-constraints December 20, 2024 19:31
@ojbucao ojbucao closed this Dec 20, 2024
@ojbucao ojbucao deleted the remove-kms-key-null-constraints-models branch December 20, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants