Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NOT NULL constraint from encrypted_kms_key in ar_power_of_attorney_request_resolutions and ar_power_of_attorney_forms #19982

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

ojbucao
Copy link
Contributor

@ojbucao ojbucao commented Dec 20, 2024

This PR removes the NOT NULL constraint from the encrypted_kms_key field in the power_of_attorney_requests table. This change allows the encrypted_kms_key field to accept NULL values.

Changes

  • Added new migrations to remove the NOT NULL constraint from the encrypted_kms_key field.
  • Updated schema.rb to reflect the changes in the database schema.

Copy link

@patrick-brown-oddball patrick-brown-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nihil2501
nihil2501 previously approved these changes Dec 20, 2024
Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ojbucao ojbucao force-pushed the remove-kms-null-constraints branch from 36ba766 to e1225f8 Compare December 20, 2024 19:59
@ojbucao ojbucao marked this pull request as ready for review December 20, 2024 20:06
@ojbucao ojbucao requested review from a team as code owners December 20, 2024 20:06
Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ojbucao ojbucao merged commit 124adcf into master Dec 20, 2024
21 of 22 checks passed
@ojbucao ojbucao deleted the remove-kms-null-constraints branch December 20, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants