Created Feature Flipper to Remove PCIU Data Requests in Pre-Fill #19981
Conversation
github-actions
bot
added
require-backend-approval
lint-failure
ready-for-backend-review
and removed
ready-for-backend-review
labels
RachalCassity
changed the title
RachalCassity
force-pushed
the
rcassity-remove-pciu-2
branch
from
75755bc to
0e0232b
Compare
github-actions
bot
added
lint-failure
test-passing
and removed
ready-for-backend-review
test-failure
lint-failure
labels
| @@ -13,6 +13,9 @@ | |||
| before do | |||
| stub_evss_pciu(user) | |||
| described_class.instance_variable_set(:@mappings, nil) | |||
| Flipper.disable(:va_v3_contact_information_service) | |||
| Flipper.disable(:remove_pciu) | |||
| Flipper.disable('remove_pciu_2') | |||
| Flipper.disable(:disability_526_toxic_exposure) | |||
| Flipper.disable(ApiProviderFactory::FEATURE_TOGGLE_PPIU_DIRECT_DEPOSIT) | |||
There was a problem hiding this comment.
Flipper is enabled in the form_profile_v2_spec in this #18729
| before do | ||
| Flipper.disable('remove_pciu_2') | ||
| end | ||
|
|
||
| let(:user) { build(:user, :loa3, address: build(:mpi_profile_address)) } |
There was a problem hiding this comment.
Flipper is enabled in the form_profile_v2_spec in this #18729
There was a problem hiding this comment.
aren't we trying to move towards mocking Flipper instead of using before actions, because it sets it globally and introduces inconsistencies?
There was a problem hiding this comment.
Exactly, this is why we need to fix these specs. I attempted to mock the flipper but due to contact information being used throughout the app and all the flipper inconsistencies, mocking will only give more errors. I even attempted to try to re-work other specs but the work kept growing.
There was a problem hiding this comment.
I accidentally made a duplicate ticket over this issue when I was drafting this PR.
RachalCassity
force-pushed
the
rcassity-remove-pciu-2
branch
from
f47b098 to
d94956b
Compare
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
The current pre-fill process includes PCIU data requests. However, in staging we need to disable these requests to ensure VAProfile Contact Information is properly pre-filling the data. When the remove_pciu_2 flipper is enabled, PCIU data will not be used to fill in missing VAProfile data.
Flipper is enabled in the form_profile_v2_spec in this #18729
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
Profile Contact Info in staging
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?