Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99537: Remove silent_failure_avoided_no_confirmation from DR jobs #19975

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dfong-adh
Copy link
Contributor

Summary

This PR removes silent_failure_avoided_no_confirmation metrics from Decision Review sidekiq jobs as we are handling email callbacks and reporting silent_failure_avoided metrics. This also corrects when silent_failure metrics are reported for sidekiq jobs that have exhausted retries.

This is owned by Benefits Decision Reviews.

Related issue(s)

department-of-veterans-affairs/va.gov-team#99537

Testing done

Tested locally

  • New code is covered by unit tests

What areas of the site does it impact?

This impacts the Decision Review sidekiq jobs

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link
Contributor

@shaunburdick shaunburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryan-mcneil
Copy link
Contributor

@dfong-adh If you merge master, it should clear it up the failing test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants