Api 43135 poa updated notification dependent

[mchristiansonVA]

Summary

• This work is behind a feature toggle (flipper): YES
• Note new VANotify for dependent claimant functionality is behind flipper lighthouse_claims_api_v2_poa_va_notify
• Sends an email notification to dependent claimants for successfully updated individual or organization POA assignment
• Uses the dependent claimant ICN for VANotify, as well as the dependent's first name in the email salutation.
• Calls job from poa_assign_dependent_claimant job when that is successful
• This workflow only applies to v2 POA

Related issue(s)

API-43135

Testing done

• New code is covered by unit tests
• Previously, no notification email was sent to dependent claimants upon successful individual or organization POA assignment.
  switching the job to use new.perform is not strictly required, but wll make it easier to step through and see.

you will need to switch out so the template sends to your email: email_address: 'you.email@here' replaces recipient_identifier: icn_for_vanotify(poa.auth_headers), for whichever you are sending
Change line 100 in the power_of_attorney/base_controller to use new.perform
Change lines 35 & 37 in the v2 PoaFormBuilderJob to use new.perform
Change line 33 in poa_assign_dependent_claimant_job.rb to use new.perform
Submit a v2 2122 or 2122a with a dependent claimant; email will be sent upon successful assignation of POA for individual or organization. The titles are: ORG: We processed your form to appoint a VSO & Rep: We processed your form to appoint an accredited representative
Confirm the resulting email includes the dependent claimant's first name in the salutation.

Screenshots

Individual/rep email

Organization email

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[tycol7]

Looking good! Minor feedback (id vs object in the sidekiq params).

[tycol7]

Instead of passing the rep object, should we plumb the rep ID and query the database again in VANotifyAcceptedJob? Have been burned before passing objects between sidekiq jobs.

[tycol7]

nit

Suggested change

	if Flipper.enabled?(:lighthouse_claims_api_v2_poa_va_notify)
	auth_headers.key?(ClaimsApi::V2::Veterans::PowerOfAttorney::BaseController::VA_NOTIFY_KEY) && rep.present?
	else
	false
	end
	Flipper.enabled?(:lighthouse_claims_api_v2_poa_va_notify) &&
	auth_headers.key?(ClaimsApi::V2::Veterans::PowerOfAttorney::BaseController::VA_NOTIFY_KEY) && rep.present?

[tycol7]

nit: we could make our intent clearer with presence.

Suggested change

	dependent_claimant_icn || params[:veteranId]
	dependent_claimant_icn.presence || params[:veteranId]

[tycol7]

nit: I missed this subtlety earlier, but we shouldnʼt need the intermediate headers variable since Ruby modifies hashes in-place. We could simplify these two methods as:

def set_auth_headers
  auth_headers.merge!(VA_NOTIFY_KEY => icn_for_vanotify)

  add_dependent_to_auth_headers if allow_dependent_claimant?

  auth_headers
end

def add_dependent_to_auth_headers
  claimant = user_profile.profile

  auth_headers.merge!({
                        dependent: {
                          participant_id: claimant.participant_id,
                          ssn: claimant.ssn,
                          first_name: claimant.given_names[0],
                          last_name: claimant.family_name
                        }
                      })
end

[tycol7]

nit

Suggested change

	claimant = poa.form_data['claimant'].present?
	if claimant
	poa.form_data['claimant']['firstName']
	else
	poa.auth_headers['va_eauth_firstName']
	end
	poa.form_data.dig('claimant', 'firstName').presence || poa.auth_headers['va_eauth_firstName']

[tycol7]

👍

[tycol7]

👍