API-42308-bgs-service-standardization

[stiehlrod]

Summary

• Removes action method definitions and for_action tests.

Related issue(s)

• API-42308

Testing done

• {{uri}}/services/claims/v2/veterans/{{veteran_id}}/power-of-attorney-request in dev
• v1 526 submit
• Tested V2 claims show
• Tested V1 claims show Flipper.enable :claims_status_v1_bgs_enabled
• Tested v1 submit_form_2122
• Tested v2 submit_form_2122

What areas of the site does it impact?

modified:   modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb
modified:   modules/claims_api/spec/lib/claims_api/find_definition_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 296 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb (+55/-126) modules/claims_api/spec/lib/claims_api/find_definition_spec.rb (+0/-115) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger