Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vebt-558-migration - add excel file events to schema #19969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexchan-va
Copy link
Contributor

@alexchan-va alexchan-va commented Dec 19, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): YES/NO No
  • (Summarize the changes that have been made to the platform) ExcelFileEvent was added to schema to track Excel file creation for the 10282 form
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?) Create a migration for the event
  • (Which team do you work for, does your team own the maintenance of this component?) VEBT
  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

  • Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira https://jira.devops.va.gov/browse/VEBT-558
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Testing done

  • Describe what the old behavior was prior to the change Excel File Events was not in the schema
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing I ran the changes that created ExcelFileEvents and checked the db that they wrote correctly
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature? Test the use of this code inside the main vebt-558 PR.

Acceptance criteria

  • [x ] No error nor warning in the console.

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants