-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10-10EZ] Add VANotify Callbacks to Failure email #19964
Conversation
@@ -419,15 +422,15 @@ | |||
expect do | |||
described_class.new(form: { mothersMaidenName: 'm' }.to_json).process! | |||
end.to raise_error(Common::Exceptions::ValidationErrors) | |||
end.to trigger_statsd_increment('api.1010ez.validation_error_short_form') | |||
end.to trigger_statsd_increment("#{statsd_key_prefix}.validation_error_short_form") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced these with a variable to DRY it up a bit. It's a little different than others since the prefix comes from the service and not the class under test, but I still like it better than hardcoding it.
@@ -542,6 +545,7 @@ def self.expect_job_submission(job) | |||
|
|||
before do | |||
allow(VANotify::EmailJob).to receive(:perform_async) | |||
allow(Flipper).to receive(:enabled?).with(:hca_zero_silent_failures).and_return(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to add this since toggles are on be default in test environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work Brandon! 😃
* add callback metadata to send failure email * add hca_zero_silent_failures flipper toggle and use it for metadata
Summary
hca_zero_silent_failures
toggleRelated issue(s)
Testing done
What areas of the site does it impact?
10-10EZ
Acceptance criteria