API-42609-health-checks-new-services

[stiehlrod]

Summary

• Adds bean name to several services.
• Adds health checks for new services.

Related issue(s)

• API-42609

Testing done

• visit http://localhost:3000/services/claims/v2/upstream_healthcheck

What areas of the site does it impact?

modified:   modules/claims_api/config/initializers/okcomputer.rb
modified:   modules/claims_api/lib/bgs_service/veteran_representative_service.rb
modified:   modules/claims_api/lib/bgs_service/vnp_atchms_service.rb
modified:   modules/claims_api/lib/bgs_service/vnp_person_service.rb
modified:   modules/claims_api/lib/bgs_service/vnp_proc_form_service.rb
modified:   modules/claims_api/lib/bgs_service/vnp_proc_service_v2.rb
modified:   modules/claims_api/lib/bgs_service/vnp_ptcpnt_addrs_service.rb
modified:   modules/claims_api/lib/bgs_service/vnp_ptcpnt_phone_service.rb
modified:   modules/claims_api/lib/bgs_service/vnp_ptcpnt_service.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 233 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/config/initializers/okcomputer.rb (+31/-15) modules/claims_api/lib/bgs_service/veteran_representative_service.rb (+3/-0) modules/claims_api/lib/bgs_service/vnp_atchms_service.rb (+3/-0) modules/claims_api/lib/bgs_service/vnp_person_service.rb (+3/-0) modules/claims_api/lib/bgs_service/vnp_proc_form_service.rb (+3/-0) modules/claims_api/lib/bgs_service/vnp_proc_service_v2.rb (+3/-0) modules/claims_api/lib/bgs_service/vnp_ptcpnt_addrs_service.rb (+3/-0) modules/claims_api/lib/bgs_service/vnp_ptcpnt_phone_service.rb (+3/-0) modules/claims_api/lib/bgs_service/vnp_ptcpnt_service.rb (+3/-0) modules/claims_api/spec/requests/metadata_spec.rb (+101/-62) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[rockwellwindsor-va]

New Health checks showed as expected.
LGTM!