-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Champva 94284 pega reporting api connection #19951
Champva 94284 pega reporting api connection #19951
Conversation
@stevelong00 after troubleshooting with Cindy we found that the headers were automatically getting converted to have an uppercase first letter. Cindy updated her python lambda to grab the headers using appropriate casing and I was able to use your existing code to pull a report in the Argo staging console. |
config/settings.yml
Outdated
prefill: true | ||
pega_api: | ||
api_key: fake_api_key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want that prefill line in here (for when users have save-in-progress'd data).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I've added the production API key to the AWS param store under this path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I wasn't sure if that prefill line was a placeholder or if it was doing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
def base_path | ||
'https://bt41mfpkj5.execute-api.us-gov-west-1.amazonaws.com/prod/' | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but we may want to move this into our AWS param store at some point in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about that, but this is how paths are being stored elsewhere in similar code so I decided to err on the side of consistency.
Summary
Related issue(s)
Testing done
Screenshots
None
What areas of the site does it impact?
None, this code is only used by unit tests so far.
Acceptance criteria
and integration testsfor each feature (if applicable).Requested Feedback
None