Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-42933-vnp-ptcpnt-phone-standardization #19943

Closed
wants to merge 1 commit into from

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Dec 18, 2024

Summary

  • Removes actions from the definitions file for vnpPtcpntPhone and vnpPtcpnt.
  • Removes the corresponding tests in the find_defintions_spec.

Related issue(s)

Testing done

  • {{uri}}/services/claims/v2/veterans/{{veteran_id}}/power-of-attorney-request in dev
  • {{uri}}/services/claims/v2/veterans/{{veteran_id}}/power-of-attorney-request in staging

What areas of the site does it impact?

modified:   modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb
modified:   modules/claims_api/spec/lib/claims_api/find_definition_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

…tcpnt. Removes the corresponding tests in the find_defintions_spec.
@stiehlrod stiehlrod self-assigned this Dec 18, 2024
@stiehlrod stiehlrod marked this pull request as ready for review December 18, 2024 15:40
@stiehlrod stiehlrod requested a review from a team as a code owner December 18, 2024 15:40
@va-vfs-bot va-vfs-bot temporarily deployed to API-42933-vnp-ptcpnt-phone-standardization/main/main December 18, 2024 15:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants