98361: Update DR engine controllers to use engine jobs

[dfong-adh]

Summary

This PR adds two feature flags to switch to the engine versions of the SubmitUpload and Form4142Submit jobs when using the Decision Review engine controllers.

decision_review_new_engine_submit_upload_job
decision_review_new_engine_4142_job

This is owned by Benefits Decision Reviews.

Related issue(s)

department-of-veterans-affairs/va.gov-team#98361

Testing done

Tested locally and via spec tests.

• New code is covered by unit tests
  The new jobs are called from the new controllers instead of the original jobs when the respective feature flag is enabled.

What areas of the site does it impact?

Controllers for the decision reviews functionality which are duplicated in engine context.

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[shaunburdick]

LGTM!

[github-actions]

1 Warning

⚠️

This PR changes 208 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files app/models/appeal_submission.rb (+5/-4) config/features.yml (+6/-0) lib/decision_review_v1/appeals/supplemental_claim_services.rb (+2/-2) lib/decision_review_v1/service.rb (+6/-0) modules/decision_reviews/app/controllers/decision_reviews/v1/notice_of_disagreements_controller.rb (+9/-1) modules/decision_reviews/lib/decision_reviews/v1/service.rb (+14/-0) modules/decision_reviews/spec/requests/v1/notice_of_disagreements_spec.rb (+52/-35) modules/decision_reviews/spec/requests/v1/supplemental_claims_spec.rb (+61/-11) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[ryan-mcneil]

Hi, I must ask if there's a way to break this PR up. It seems to be an unnecessary amount of functionality to add in a single PR. While I understand that some changes require everything to go in at once, this seems like something that can go in piece by piece. We have the 500 LOC rule for a reason - please try to break down.

[ryan-mcneil]

Please break down into smaller PRs

[dfong-adh]

Sorry about that - this PR was waiting for #19789 to be merged, so most of the commits were duplicated off of those. I'll merge and update so it'll make the PR smaller.

[dfong-adh]

PR is ready for review.

[shaunburdick]

LGTM*

* G = Gooder