-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VI-252] MAP STS token validation #19907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
bosawt
reviewed
Dec 17, 2024
bosawt
reviewed
Dec 17, 2024
va-vfs-bot
temporarily deployed
to
VI-252_map_sts_validation/main/main
December 17, 2024 19:40
Inactive
bramleyjl
force-pushed
the
VI-252_map_sts_validation
branch
from
December 17, 2024 22:55
8072f78
to
b51b540
Compare
va-vfs-bot
temporarily deployed
to
VI-252_map_sts_validation/main/main
December 17, 2024 23:02
Inactive
bramleyjl
force-pushed
the
VI-252_map_sts_validation
branch
from
December 18, 2024 16:58
b51b540
to
6544910
Compare
va-vfs-bot
temporarily deployed
to
VI-252_map_sts_validation/main/main
December 18, 2024 17:06
Inactive
va-vfs-bot
temporarily deployed
to
VI-252_map_sts_validation/main/main
December 18, 2024 17:48
Inactive
bramleyjl
force-pushed
the
VI-252_map_sts_validation
branch
from
December 18, 2024 22:54
173d25b
to
a0260af
Compare
va-vfs-bot
temporarily deployed
to
VI-252_map_sts_validation/main/main
December 18, 2024 23:03
Inactive
randomsync
reviewed
Dec 19, 2024
modules/check_in/spec/requests/check_in/v2/sessions/appointments_spec.rb
Show resolved
Hide resolved
ryan-mcneil
previously approved these changes
Dec 19, 2024
randomsync
previously approved these changes
Dec 19, 2024
bramleyjl
dismissed stale reviews from randomsync, ryan-mcneil, and emilykim13
via
January 3, 2025 20:38
fb728f3
bramleyjl
force-pushed
the
VI-252_map_sts_validation
branch
from
January 3, 2025 20:38
dea2155
to
fb728f3
Compare
va-vfs-bot
temporarily deployed
to
VI-252_map_sts_validation/main/main
January 3, 2025 20:43
Inactive
bramleyjl
force-pushed
the
VI-252_map_sts_validation
branch
from
January 3, 2025 20:56
762441d
to
1eb98b8
Compare
va-vfs-bot
temporarily deployed
to
VI-252_map_sts_validation/main/main
January 3, 2025 21:02
Inactive
va-vfs-bot
temporarily deployed
to
VI-252_map_sts_validation/main/main
January 6, 2025 19:26
Inactive
bosawt
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed staging and production routes are reachable
LindseySaari
approved these changes
Jan 7, 2025
10 tasks
bosawt
added a commit
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PublicJwks
& cached in Redis for 30 minutes, Redis key ismap_public_jwks
.JWT:DecodeError
that is logged and re-raised at the MAP service level and returns a502 bad gateway
error at the MAP controller level.Related issue(s)
Testing done
vets-api-mockdata
is active and is on the latest ofmaster
to include the mockdata changes linked above.access_token
[MAP][SecurityToken][Service] Get Public JWKs Success
access_token
in the body of the mockdata file atvets-api-mockdata/map/secure_token_service/token.yml
to change the token response (yourvets-api
instance should now be maintaining the JWK if you don't restart it) & make the MAP token request again502 bad gateway
error[MAP][SecurityToken][Service] token failed, JWT decode error -- { :application => :chatbot, :icn => <icn>, :context => "Signature verification failed" }
in your Rails logsWhat areas of the site does it impact?
MAP STS token requests
Acceptance criteria
JWT::DecodeError
.