95915 Add pega notification email workflow - IVC CHAMPVA forms #19795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelclement
commented
Dec 9, 2024
| @@ -1361,6 +1361,7 @@ vanotify: | |||
| ivc_champva: | |||
| api_key: fake_secret | |||
| failure_email_threshold_days: 7 | |||
| pega_inbox_address: fake_email_address | |||
There was a problem hiding this comment.
This will be populated with the current Pega email address via AWS param
michaelclement
commented
Dec 9, 2024
| @@ -29,9 +29,10 @@ def perform # rubocop:disable Metrics/MethodLength | |||
| template_id = "#{form[:form_number]}-FAILURE" | |||
| send_failure_email(form, template_id) | |||
| if Flipper.enabled?(:champva_enhanced_monitor_logging, @current_user) | |||
| additional_context = { form_id: form[:form_number] } | |||
| additional_context = { form_id: form[:form_number], form_uuid: form[:form_uuid] } | |||
There was a problem hiding this comment.
Adding additional context for logging
michaelclement
commented
Dec 9, 2024
Comment on lines
-47
to
75
| def fetch_forms_by_uuid(form_uuid) | ||
| @fetch_forms_by_uuid ||= IvcChampvaForm.where(form_uuid:) | ||
| def construct_email_payload(form, template_id) | ||
| { email: form.email, | ||
| first_name: form.first_name, | ||
| last_name: form.last_name, | ||
| form_number: form.form_number, | ||
| file_count: nil, | ||
| pega_status: form.pega_status, | ||
| created_at: form.created_at.strftime('%B %d, %Y'), | ||
| template_id: template_id, | ||
| form_uuid: form.form_uuid } | ||
| end | ||
|
|
||
| # Sends an email to user notifying them of their submission's failure | ||
| # | ||
| # @param form [IvcChampvaForm] form object in question | ||
| # @param template_id [string] key for template to use in `IvcChampva::Email::EMAIL_TEMPLATE_MAP` | ||
| def send_failure_email(form, template_id) | ||
| form_data = | ||
| { | ||
| email: form.email, | ||
| first_name: form.first_name, | ||
| last_name: form.last_name, | ||
| form_number: form.form_number, | ||
| file_count: nil, | ||
| pega_status: form.pega_status, | ||
| created_at: form.created_at.strftime('%B %d, %Y'), | ||
| template_id: template_id | ||
| } | ||
| form_data = construct_email_payload(form, template_id) | ||
| ActiveRecord::Base.transaction do | ||
| if IvcChampva::Email.new(form_data).send_email | ||
| fetch_forms_by_uuid(form[:form_uuid]).update_all(email_sent: true) # rubocop:disable Rails/SkipsModelValidations | ||
| else | ||
| additional_context = { form_id: form[:form_number] } | ||
| additional_context = { form_id: form[:form_number], form_uuid: form[:form_uuid] } | ||
| monitor.log_silent_failure(additional_context) | ||
| raise ActiveRecord::Rollback, 'Pega Status Update/Action Required Email send failure' | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Pulled the email payload construction out into its own function so it could be cleanly shared with the new send_zsf_notification_to_pega function.
michaelclement
commented
Dec 9, 2024
Comment on lines
+45
to
+62
|
|
||
| def track_send_zsf_notification_to_pega(form_uuid) | ||
| additional_context = { | ||
| form_uuid: | ||
| } | ||
| track_request('info', "IVC ChampVA Forms - alerted Pega of ZSF email sent for submission #{form_uuid}", | ||
| "#{STATS_KEY}.send_zsf_notification_to_pega", | ||
| call_location: caller_locations.first, **additional_context) | ||
| end | ||
|
|
||
| def track_failed_send_zsf_notification_to_pega(form_uuid) | ||
| additional_context = { | ||
| form_uuid: | ||
| } | ||
| track_request('warn', "IVC ChampVA Forms - could not alert Pega of ZSF email sent for submission #{form_uuid}", | ||
| "#{STATS_KEY}.failed_send_zsf_notification_to_pega", | ||
| call_location: caller_locations.first, **additional_context) | ||
| end |
There was a problem hiding this comment.
Additional logging in the IVC monitor class
va-vfs-bot
temporarily deployed
to
add-pega-notification-email-workflow/main/main
cloudmagic80
previously approved these changes
Dec 10, 2024
cloudmagic80
approved these changes
Dec 10, 2024
ericboehs
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an email trigger to alert the downstream Pega service when we've fired a ZSF email off to a user. It lets the Pega team keep abreast of any issues to which users have been alerted.
IvcChampva::MonitorclassRelated issue(s)
Testing done
Screenshots
NA
What areas of the site does it impact?
IvcChampvamodule onlyAcceptance criteria
Requested Feedback
NA