API-43192-recordconstent-bug-fix #19792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates `enable_vbms_access` check * As per the ticket, the `constentLimits` is not clear on how or if that factors into this so the check doe sremove that and not replace it, discovery to come on that, the check was not really blocking snce it was setting previously to it getting there in the workflow anyways * Updates related `poa_updater` and `poa_vbms_updater` tests * Adds one additional test for this scenario * Refactors the flipper handling * Enables VBMS Updater job to run no matter what and send in 'y' or 'n' as per the form data modified: modules/claims_api/app/sidekiq/claims_api/poa_updater.rb modified: modules/claims_api/app/sidekiq/claims_api/poa_vbms_updater.rb modified: modules/claims_api/app/sidekiq/claims_api/service_base.rb modified: modules/claims_api/spec/sidekiq/poa_updater_spec.rb modified: modules/claims_api/spec/sidekiq/poa_vbms_updater_spec.rb
…clude additional logger data
va-vfs-bot
temporarily deployed
to
API-43192-recordconstent-bug-fix/main/main
va-vfs-bot
temporarily deployed
to
API-43192-recordconstent-bug-fix/main/main
va-vfs-bot
temporarily deployed
to
API-43192-recordconstent-bug-fix/main/main
va-vfs-bot
temporarily deployed
to
API-43192-recordconstent-bug-fix/main/main
tycol7
reviewed
Dec 11, 2024
FonzMP
reviewed
Dec 11, 2024
* Updates default variable * Cleans up variable setting in vbms updater * Cleans up method signature in vbms updater * Adjusts tests to be inline with other recent code changes modified: modules/claims_api/app/sidekiq/claims_api/poa_vbms_updater.rb modified: modules/claims_api/lib/bgs_service/corporate_update_web_service.rb modified: modules/claims_api/spec/sidekiq/poa_vbms_updater_spec.rb
stiehlrod
reviewed
Dec 11, 2024
stiehlrod
previously approved these changes
Dec 11, 2024
tycol7
approved these changes
Dec 12, 2024
ericboehs
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
enable_vbms_accesscheckpoa_updater,service_baseandpoa_vbms_updatertestsallow_poa_accessandallow_poa_c_addto log outRelated issue(s)
API-43192
Testing done
Testing Notes
eFolder Accessto 'No' (any combination should work)"recordConsent": false"consentLimits": ["DRUG_ABUSE"]<--- or any of the other values from the ENUMScreenshots
What areas of the site does it impact?
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?