API-42922-org-web-service

[stiehlrod]

Summary

• Renames org web service and removes unneeded methods.

Related issue(s)

• API-42922

Testing done

• in localBgs we have one method that uses the orgWebService find_poa_history_by_ptcpnt_id and it doesn't appear to be used anywhere.

What areas of the site does it impact?

modified:   modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb
modified:   modules/claims_api/spec/lib/claims_api/find_definition_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[rockwellwindsor-va]

@stiehlrod Hey a little confused by the comment in the PR.

in localBgs we have one method that uses the orgWebService find_poa_history_by_ptcpnt_id and it doesn't appear to be used anywhere.

Is that not used in module/veteran/app/models/veteran/user.rb ? Also wondering if the fact that file is outside the claims api module means we can ignore it here and my comment is moot, OR that we may need to address the local BGS being used in this file as well?

Just trying to get some context.

[stiehlrod]

@stiehlrod Hey a little confused by the comment in the PR.

in localBgs we have one method that uses the orgWebService find_poa_history_by_ptcpnt_id and it doesn't appear to be used anywhere.

Is that not used in module/veteran/app/models/veteran/user.rb ? Also wondering if the fact that file is outside the claims api module means we can ignore it here and my comment is moot, OR that we may need to address the local BGS being used in this file as well?

Just trying to get some context.

@rockwellwindsor-va This responsibility belongs to this PR