add better error logging

[cloudmagic80]

Summary

• *This work is behind a feature toggle (flipper): NO

There are several improvements to the stamp_pdf method, enhancing both its efficiency and error handling:

1. Early Return for File Existence Check:
   Instead of using an if/else block to check if the file exists, it will now use an early return (return unless File.exist?(stamped_template_path)) This simplifies the code and reduces nesting, making it more readable.

2. Added Robust Error Handling:
   This PR will introduce a rescue block to gracefully handle potential errors during the PDF stamping process. This ensures the application doesn't crash if something goes wrong.

3. Improved Error Logging:
   Inside the rescue block, there is now log the error message (Rails.logger.error "Error stamping PDF: #{e.message}"), providing more context for debugging by including the specific exception message.

4.More Informative Error Raising:
When re-raising the error, it will provide a more general message (raise "Error stamping PDF: #{stamped_template_path}") that focuses on the action (stamping the PDF) rather than just the file existence. This gives a clearer indication of where the problem occurred.

Related issue(s)

https://github.com/orgs/department-of-veterans-affairs/projects/1533/views/1?sliceBy%5Bvalue%5D=Sprint+5&filterQuery=parent-issue%3A%22department-of-veterans-affairs%2Fva.gov-team%2395910%22&pane=issue&itemId=87423266&issue=department-of-veterans-affairs%7Cva.gov-team%7C97231

Testing done

• [x ] New code is covered by unit tests
• Ran 7959f2 and 1010d with supporting doc.

Note: Optional

What areas of the site does it impact?

IVC CHAMPVA forms

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.