-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDM-346/enable gids flight school mocks #19649
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
EDM-346/enable-gids-flight-school-mocks/main/main
November 27, 2024 20:23
Inactive
va-vfs-bot
temporarily deployed
to
EDM-346/enable-gids-flight-school-mocks/main/main
November 27, 2024 21:14
Inactive
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Nov 29, 2024
rjohnson2011
approved these changes
Nov 29, 2024
Backend-review-group approval confirmed. |
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Nov 29, 2024
binq
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GI::SearchClient
endpoints for comparison tool.GI::SearchClient
andGI::SearchConfiguration
updated to only use mocks on a request toinstitution_programs
search endpoint when a query parameter oftype == 'FLGT'
is presentuse_mocks?
Related issue(s)
What areas of the site does it impact?
GI Bill Comparison Tool
Acceptance criteria