Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDM-346/enable gids flight school mocks #19649

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

jefftmarks
Copy link
Contributor

@jefftmarks jefftmarks commented Nov 27, 2024

Summary

  • *This work is behind a feature toggle (flipper): NO
  • (Summarize the changes that have been made to the platform): App and betamocks settings updated to enable mock data for GI::SearchClient endpoints for comparison tool. GI::SearchClient and GI::SearchConfiguration updated to only use mocks on a request to institution_programs search endpoint when a query parameter of type == 'FLGT' is present
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?) Temporarily solution to test new GI Comparison Tool feature until flight program data is made available via WEAMS, which is being worked in parallel. There didn't appear to be a way in betamocks settings to only mock responses if a specific query parameter is passed in, while letting all other requests go through. So some additional logic was added to search client and search configuration's use_mocks?
  • (Which team do you work for, does your team own the maintenance of this component?) Education Data Migration (EDM), yes
  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

What areas of the site does it impact?

GI Bill Comparison Tool

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to EDM-346/enable-gids-flight-school-mocks/main/main November 27, 2024 20:23 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to EDM-346/enable-gids-flight-school-mocks/main/main November 27, 2024 21:14 Inactive
Copy link

Backend-review-group approval confirmed.

@jefftmarks jefftmarks requested a review from binq November 29, 2024 18:06
Copy link
Contributor

@binq binq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefftmarks jefftmarks merged commit 2dfa7f7 into master Nov 29, 2024
61 checks passed
@jefftmarks jefftmarks deleted the EDM-346/enable-gids-flight-school-mocks branch November 29, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants