Catch more errors in NotificationEmail #19640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
catch-more-errors-in-notification-email/main/main
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
pennja
reviewed
Dec 2, 2024
modules/simple_forms_api/spec/services/notification_email_spec.rb
Outdated
Show resolved
Hide resolved
github-actions
bot
added
require-backend-approval
ready-for-backend-review
and removed
require-backend-approval
test-passing
labels
pennja
approved these changes
Dec 2, 2024
rjohnson2011
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR catches a few more error cases where we are currently just silently
returning out. We should instead be incrementing asilent_failureStatsD metric, so this PR does that.