-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API-41329-dependent-option-in-docs-dropdown #19585
API-41329-dependent-option-in-docs-dropdown #19585
Conversation
* Adds dropdown request examples for veteran POA submission (self) and dependent POA submission * Compiles V1 Docs to include dropdown with altered request example modified: modules/claims_api/app/swagger/claims_api/v1/swagger.json modified: modules/claims_api/spec/requests/v1/forms/rswag_2122_spec.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spec looks good, but i think the v1 swagger generator is broken, leading to these large diffs. is there any way we can stage only the changes to the power of attorney request?
}, | ||
'POA for Dependent Claimant' => { | ||
value: request_template_with_dependent | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra line break
Or not 01e7d11 |
Summary
Related issue(s)
API-42567
Testing done
Screenshots
Original V1 for Veteran Submission
New V1 Submission for Dependent
What areas of the site does it impact?
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?