Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-41329-dependent-option-in-docs-dropdown #19585

Merged

Conversation

rockwellwindsor-va
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va commented Nov 22, 2024

Summary

  • Adds dropdown request examples for veteran POA submission (self) and dependent POA submission
  • Compiles V1 Docs to include dropdown with altered request example

Related issue(s)

API-42567

Testing done

  • Visual Verification

Screenshots

  • Original V1 for Veteran Submission
    Screenshot 2024-11-25 at 11 19 30 AM

  • New V1 Submission for Dependent
    Screenshot 2024-11-25 at 11 19 39 AM

What areas of the site does it impact?

modified:   modules/claims_api/app/swagger/claims_api/v1/swagger.json
modified:   modules/claims_api/spec/requests/v1/forms/rswag_2122_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

* Adds dropdown request examples for veteran POA submission (self) and dependent POA submission
* Compiles V1 Docs to include dropdown with altered request example
	modified:   modules/claims_api/app/swagger/claims_api/v1/swagger.json
	modified:   modules/claims_api/spec/requests/v1/forms/rswag_2122_spec.rb
Copy link
Contributor

@tycol7 tycol7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec looks good, but i think the v1 swagger generator is broken, leading to these large diffs. is there any way we can stage only the changes to the power of attorney request?

},
'POA for Dependent Claimant' => {
value: request_template_with_dependent

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra line break

@rockwellwindsor-va
Copy link
Contributor Author

rockwellwindsor-va commented Nov 23, 2024

spec looks good, but i think the v1 swagger generator is broken, leading to these large diffs. is there any way we can stage only the changes to the power of attorney request?

To be honest, this process, frankly, is already hacky enough. I think I would prefer to either find a solution to fix how it works or just leave it as is. Copying and pasting just the changes isn't maintainable. I'll dig into it and see if I can pinpoint when that started to change and see if that gives any insight into what exactly is going on.

Or not 01e7d11

@rockwellwindsor-va rockwellwindsor-va marked this pull request as draft November 23, 2024 00:14
@rockwellwindsor-va rockwellwindsor-va merged commit 68ef67b into master Nov 26, 2024
38 checks passed
@rockwellwindsor-va rockwellwindsor-va deleted the API-41329-dependent-option-in-docs-dropdown branch November 26, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants