Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10-10CG] Move auth_token_path to config #19581

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

coope93
Copy link
Contributor

@coope93 coope93 commented Nov 22, 2024

Summary

  • This work is behind a feature toggle (flipper): YES
  • Moving the auth_token_path from vets-api const to a config due to the possibility of future changes to it.
  • 1010 Health Apps
  • this is behind the cg1010_oauth_2_enabled flipper toggle

Related issue(s)

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

10-10CG

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@coope93 coope93 marked this pull request as ready for review November 22, 2024 18:53
@coope93 coope93 requested review from a team as code owners November 22, 2024 18:53
Copy link
Contributor

@JoshingYou1 JoshingYou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work Brandon 😄

Copy link

Backend-review-group approval confirmed.

@coope93 coope93 merged commit 5cf671e into master Nov 25, 2024
35 of 36 checks passed
@coope93 coope93 deleted the coope93-update-oauth-token-path branch November 25, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants