Rc vebt 777 revised - draft PR

[nfstern02]

Summary

• *This work is behind a feature toggle (flipper): NO
• Vye api dgib - Add API's to connect to four DGIB endpoints for VYE verifications
• (If bug, how to reproduce) N/A
• need API's for front end to call to get and post verification data to DGIB endpoints
• VEBT
• (If introducing a flipper, what is the success criteria being targeted?) N/A

Related issue(s)

• VEBT-777
• vye-api-dgib

Testing done

• New code is covered by unit tests
• did not have API's to DGIB endpoints
• QA logs in with a test user, goes to /education/verify-school-enrollement/mgib-enrollments/, confirms that claimant id and verfiication data populates and verify claimant works as expected.
• If this work is behind a flipper: N/A
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature? QA to test on staging, if works as expected, deploy to production. Note: front end related work that calls these API's is behind a feature flag.

What areas of the site does it impact?

VYE enrollment verifications

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/policies/vye_policy.rb

[github-actions]

1 Error

🚫

This PR changes 600 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones. If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ. File Summary Files .rubocop_todo.yml (+3/-0) app/policies/vye_policy.rb (+7/-0) config/environments/development.rb (+1/-1) config/initializers/breakers.rb (+2/-0) config/settings.yml (+10/-2) modules/vye/app/controllers/vye/v1/dgib_verifications_controller.rb (+64/-0) modules/vye/app/serializers/vye/verification_serializer.rb (+7/-7) modules/vye/app/serializers/vye/vye_serializer.rb (+42/-0) modules/vye/config/initializers/dgib_requires.rb (+1/-0) modules/vye/config/routes.rb (+4/-0) modules/vye/lib/dgib/authentication_token_service.rb (+24/-0) modules/vye/lib/dgib/configuration.rb (+27/-0) modules/vye/lib/dgib/response.rb (+93/-0) modules/vye/lib/dgib/service.rb (+97/-0) modules/vye/spec/controllers/vye/v1/dgib_verifications_controller_spec.rb (+96/-0) modules/vye/spec/dgib/service_spec.rb (+90/-0) modules/vye/spec/serializers/claimant_verification_serializer_spec.rb (+22/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[RachalCassity]

Please undo this change

[RachalCassity]

'vye/dgib/configuration'

[RachalCassity]

module Vye
  module V1
    class DgibVerificationsController < Vye::V1::ApplicationController

[RachalCassity]

What does this file do?

[GcioGregg]

This file was intended to resolve namespace problems. Now it is no longer needed as the namespace issues were fixed.

[RachalCassity]

'VYE/DGIB' There is already a DGI service

[RachalCassity]

'vye/dgib/service'

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR has been closed because it has had no activity for 37 days