Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

97028: Add error bucketing for DR job statuses #19568

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

dfong-adh
Copy link
Contributor

@dfong-adh dfong-adh commented Nov 21, 2024

Summary

  • This work is behind a feature toggle (flipper): NO

To better analyze the types of errors we receive from LH submissions, this adds a new tag to the logged error message to bucket the errors into specific categories.

Related issue(s)

department-of-veterans-affairs/va.gov-team#97028

Testing done

Manually tested

  • New code is covered by unit tests
    The logged error will now have a param error_type to categorize the errors for use in DD dashboards.

What areas of the site does it impact?

Logged messages for DR SavedClaim status updater jobs

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link
Contributor

@kayline kayline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

Backend-review-group approval confirmed.

@dfong-adh dfong-adh merged commit a8872e4 into master Nov 25, 2024
50 checks passed
@dfong-adh dfong-adh deleted the 97028-DR-status-job-error-bucketing branch November 25, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants