Move Decision Review code to Engine - spike

[kayline]

Summary

• This work is behind a feature toggle (flipper): YES
• (Summarize the changes that have been made to the platform)
  Move some Decision Review controllers and Sidekiq jobs into a new engine in the modules folder. Spike to help team decide if we want to pursue full code isolation.
• (Which team do you work for, does your team own the maintenance of this component?)
  Decision Reviews, yes
• (If introducing a flipper, what is the success criteria being targeted?)
  No flipper, no changes to behavior just refactoring. Initial plan is to keep routes and controllers in main app and engine while we test the transition.

Related issue(s)

department-of-veterans-affairs/va.gov-team#97410

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
  Code was not contained in an engine
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  Check the new engine endpoints behave the same way as existing endpoints

What areas of the site does it impact?

DR endpoints and background jobs

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: app/controllers/v1/decision_review_notification_callbacks_controller.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: modules/decision_reviews/Gemfile

[github-actions]

1 Error

🚫

This PR changes 1206 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones. If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ. File Summary Files .github/CODEOWNERS (+1/-0) Gemfile (+1/-0) config/routes.rb (+1/-0) lib/periodic_jobs.rb (+1/-1) modules/decision_reviews/Gemfile (+2/-0) modules/decision_reviews/Rakefile (+14/-0) modules/decision_reviews/app/controllers/decision_reviews/v1/appeals_base_controller.rb (+34/-0) modules/decision_reviews/app/controllers/decision_reviews/v1/decision_review_evidences_controller.rb (+63/-0) modules/decision_reviews/app/controllers/decision_reviews/v1/decision_review_notification_callbacks_controller.rb (+82/-0) modules/decision_reviews/app/controllers/decision_reviews/v1/notice_of_disagreements_controller.rb (+45/-0) {app/sidekiq/decision_review => modules/decision_reviews/app/sidekiq/decision_reviews}/delete_saved_claim_records_job.rb (+1/-1) {app/sidekiq/decision_review => modules/decision_reviews/app/sidekiq/decision_reviews}/nod_email_loader_job.rb (+4/-4) {app/sidekiq/decision_review => modules/decision_reviews/app/sidekiq/decision_reviews}/nod_send_email_job.rb (+3/-3) modules/decision_reviews/bin/rails (+6/-0) modules/decision_reviews/config/routes.rb (+7/-0) modules/decision_reviews/decision_reviews.gemspec (+16/-0) modules/decision_reviews/lib/decision_reviews.rb (+5/-0) modules/decision_reviews/lib/decision_reviews/engine.rb (+6/-0) modules/decision_reviews/lib/decision_reviews/v1/logging_utils.rb (+79/-0) modules/decision_reviews/lib/decision_reviews/v1/service.rb (+356/-0) modules/decision_reviews/lib/decision_reviews/version.rb (+4/-0) modules/decision_reviews/spec/controllers/v1/decision_review_evidences_controller_spec.rb (+177/-0) modules/decision_reviews/spec/controllers/v1/decision_review_notification_callbacks_controller_spec.rb (+124/-0) modules/decision_reviews/spec/controllers/v1/notice_of_disagreements_spec.rb (+145/-0) {spec/sidekiq/decision_review => modules/decision_reviews/spec/sidekiq}/delete_saved_claim_records_job_spec.rb (+1/-1) {spec/sidekiq/decision_review => modules/decision_reviews/spec/sidekiq}/nod_email_loader_job_spec.rb (+6/-7) {spec/sidekiq/decision_review => modules/decision_reviews/spec/sidekiq}/nod_send_email_job_spec.rb (+1/-1) modules/decision_reviews/spec/spec_helper.rb (+3/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[kayline]

Spike complete, starting feature work on new branch, closing this PR