Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-42282] Improve error handling and logging for POA dependent assignment #19541

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

tycol7
Copy link
Contributor

@tycol7 tycol7 commented Nov 21, 2024

Summary

Update the POA dependent assignment service to more robustly handle errors and log more meaningful messages.

  • Add POA ID to logs.
  • Do not fall back to update_benefit_claim? if manage_ptcpnt_rlnshp? fails unexpectedly; instead, raise an error.

Related issue(s)

API-42282

Testing done

  • Manual calls to BGS.

Screenshots

N/A

What areas of the site does it impact?

Dependent claimant POA assignment service.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

N/A

@tycol7 tycol7 added the claimsApi modules/claims_api label Nov 21, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/improve-error-handling-poa/main/main November 21, 2024 00:13 Inactive
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. Including screenshots of the log output just to double check that everything looks as you expected, it looked like what I would have expected.

  • Failing to assign log out
Screenshot 2024-11-22 at 8 17 40 AM * What we will see in sidekiq on this one ![Screenshot 2024-11-22 at 8 17 51 AM](https://github.com/user-attachments/assets/db6c744f-7258-47ba-b55e-29aa4287af3d)
  • Something else went wrong log out
Screenshot 2024-11-22 at 8 30 42 AM

Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looked solid, once again including screenshots just to make sure it matches what you had in mind. Error generated was quite forced so might not be best example.

Screenshot 2024-11-25 at 1 21 37 PM

@tycol7 tycol7 merged commit 7f26785 into master Nov 25, 2024
26 checks passed
@tycol7 tycol7 deleted the tdc/improve-error-handling-poa branch November 25, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants