92770: Add JSON schema validation for Form 21a submissions #19510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SchemaValidationError class to handle validation failures - Add schema validation to form submission pipeline - Use VetsJsonSchema to validate form structure - Add error logging for schema validation failures - Add request specs for schema validation failures The validation now ensures Form 21a submissions match the expected schema structure before being processed.
- Fix rubocop errors regarding spaces and strings literal formats
- Replace forward slash delimiters with %r{} for better readability
- Format multi-line regex pattern to improve maintainability
- Avoid escaping forward slashes in error message pattern
- Retain original matching functionality for Form21a JSON validation error
- Revert multiline formatting to maintain exact pattern match - Fix failing specs for Form21a JSON validation errors - Keep %r syntax improvement but remove heredoc style
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
|
I had to delete the old one because the linting part kept trying to use the unmodified code and wouldn't pass. So I'm recreating this PR. |
github-actions
bot
added
require-backend-approval
test-passing
ready-for-backend-review
and removed
require-backend-approval
labels
va-vfs-bot
temporarily deployed
to
art/92770/backend-form21a-json-schema-validation-b/main/main
RachalCassity
approved these changes
Nov 20, 2024
|
Backend-review-group approval confirmed. |
github-actions
bot
added
require-backend-approval
test-passing
ready-for-backend-review
and removed
require-backend-approval
test-passing
labels
va-vfs-bot
temporarily deployed
to
art/92770/backend-form21a-json-schema-validation-b/main/main
rjohnson2011
deleted the
art/92770/backend-form21a-json-schema-validation-b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SchemaValidationError class to handle validation failures
Add schema validation to form submission pipeline
Use VetsJsonSchema to validate form structure
Add error logging for schema validation failures
Add request specs for schema validation failures
The validation now ensures Form 21a submissions match the expected schema structure before being processed.