Handle separate emails for different 21-0966 paths

[Thrillberg]

Summary

This PR differentiates between 21-0966s that are submitted async vs sync so that we send a different email in each case, upon submission.

Related issue(s)

https://github.com/orgs/department-of-veterans-affairs/projects/1443/views/3?sliceBy%5Bvalue%5D=Thrillberg&pane=issue&itemId=86250028&issue=department-of-veterans-affairs%7CVA.gov-team-forms%7C1841

[github-actions]

1 Warning

⚠️

This PR changes 203 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files config/settings.yml (+2/-0) modules/simple_forms_api/app/controllers/simple_forms_api/v1/uploads_controller.rb (+16/-1) modules/simple_forms_api/app/services/simple_forms_api/notification_email.rb (+39/-18) modules/simple_forms_api/spec/requests/simple_forms_api/v1/simple_forms_spec.rb (+12/-7) modules/simple_forms_api/spec/services/notification_email_spec.rb (+93/-15) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[pennja]

Looks good, great work! 👍

[github-actions]

Backend-review-group approval confirmed.