Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature toggle for Vet Status card LH API usage #19473

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

khenson-oddball
Copy link
Contributor

@khenson-oddball khenson-oddball commented Nov 14, 2024

Summary

  • This PR adds a feature toggle for the Veteran Status card feature to use the Lighthouse API instead of the Profile API. This will help our team test out this new API integration.
  • I work on the IIR Product team and we currently own this feature.
  • The success criteria targeted is to make sure that we receive the same access rate or better for known test users when trying to view their Vet Status card.
  • The companion vets-website PR is here.

Related issue(s)

Testing done

  • This change only includes adding a new feature toggle.

What areas of the site does it impact?

This change only includes adding a new feature toggle.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@khenson-oddball khenson-oddball marked this pull request as ready for review November 19, 2024 19:02
@khenson-oddball khenson-oddball requested review from a team as code owners November 19, 2024 19:02
@RachalCassity RachalCassity self-assigned this Nov 20, 2024
Copy link

Backend-review-group approval confirmed.

@khenson-oddball khenson-oddball merged commit 7ba1f71 into master Nov 20, 2024
54 checks passed
@khenson-oddball khenson-oddball deleted the iir-1144-add-vet-status-lh-feature-toggle branch November 20, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants