Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form 21-22a: Fill in questions 19a and 19b on generated PDF #19460

Conversation

opticbob
Copy link
Contributor

@opticbob opticbob commented Nov 14, 2024

Summary

  • This work is behind a feature toggle (flipper): YES
  • (Summarize the changes that have been made to the platform): On the 21-22a PDF fills in the checkboxes for 19a and 19b, the text field for 19b, and corrects the text handling around limitations of consent.
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?)
  • (Which team do you work for, does your team own the maintenance of this component?): FAR/ARM, we own this component.
  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change: The question 19 fields weren't filled in at all and the limitations of consent weren't filled in correctly.
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing: Use the staging frontend to create a PDF generation data request and submit it to the backend. You should get a PDF generated and returned to you.
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Screenshot 2024-11-15 155920

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas): Just the 'representation_management` module.

Acceptance criteria

  • I updated unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to 96908-include-specific-21-22a-authorizations-fields-19a-and-19b-in-pdf-generation/main/main November 14, 2024 17:37 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 96908-include-specific-21-22a-authorizations-fields-19a-and-19b-in-pdf-generation/main/main November 14, 2024 19:38 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 96908-include-specific-21-22a-authorizations-fields-19a-and-19b-in-pdf-generation/main/main November 14, 2024 21:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 96908-include-specific-21-22a-authorizations-fields-19a-and-19b-in-pdf-generation/main/main November 14, 2024 22:09 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 96908-include-specific-21-22a-authorizations-fields-19a-and-19b-in-pdf-generation/main/main November 15, 2024 17:25 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 96908-include-specific-21-22a-authorizations-fields-19a-and-19b-in-pdf-generation/main/main November 15, 2024 20:04 Inactive
Copy link
Contributor

@holdenhinkle holdenhinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link

Backend-review-group approval confirmed.

@opticbob opticbob merged commit cc03376 into master Nov 18, 2024
48 of 49 checks passed
@opticbob opticbob deleted the 96908-include-specific-21-22a-authorizations-fields-19a-and-19b-in-pdf-generation branch November 18, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants