Api 36674 new supp claim form

[michelpmcdonald]

Summary

New Supplemental Claim form, we are calling it v4.

New form is behind flipper flag, decision_review_sc_form_v4_enabled. We don't have any immediate plans to take this live at this point.

Related issue(s)

API-36674

Testing done

• New code is covered by unit tests

We have standard test data for supp claims. Used test data to generate forms and manually confirmed the forms are as expected. The generated files become PDF reference unit test fixtures, unit test generates forms and the compairs the generated from with the ref fixture.

What areas of the site does it impact?

Intake will start receiving and processing the latest version of the Va supp claim form.
Since the form we generate is an internal implementation detail and not directly exposed to consumers, there are no changes for them at this point.

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)

[github-actions]

1 Warning

⚠️

This PR changes 481 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files config/features.yml (+4/-0) modules/appeals_api/app/controllers/appeals_api/v2/decision_reviews/supplemental_claims_controller.rb (+5/-1) modules/appeals_api/app/models/appeals_api/supplemental_claim.rb (+3/-0) modules/appeals_api/app/services/appeals_api/pdf_construction/supplemental_claim/v2/form_data.rb (+1/-1) modules/appeals_api/app/services/appeals_api/pdf_construction/supplemental_claim/v3/form_data.rb (+1/-1) modules/appeals_api/app/services/appeals_api/pdf_construction/supplemental_claim/v4/form_data.rb (+224/-0) modules/appeals_api/app/services/appeals_api/pdf_construction/supplemental_claim/v4/pages/additional_pages.rb (+62/-0) modules/appeals_api/app/services/appeals_api/pdf_construction/supplemental_claim/v4/structure.rb (+145/-0) modules/appeals_api/lib/appeals_api/sc_evidence.rb (+8/-1) modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb (+8/-3) modules/appeals_api/spec/support/shared_examples_for_gateway_origin_check.rb (+7/-6) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[github-actions]

Backend-review-group approval confirmed.