Delete DirectDepositEmailJob
#18855
Merged
Delete DirectDepositEmailJob
#18855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: app/sidekiq/direct_deposit_email_job.rb |
va-vfs-bot
temporarily deployed
to
delete_direct_deposit_email_job/main/main
tpharrison
approved these changes
Oct 11, 2024
va-vfs-bot
temporarily deployed
to
delete_direct_deposit_email_job/main/main
github-actions
bot
added
require-backend-approval
omit-backend-approval
and removed
require-backend-approval
omit-backend-approval
labels
github-actions
bot
added
omit-backend-approval
test-passing
ready-for-backend-review
and removed
omit-backend-approval
test-passing
labels
stevenjcumming
approved these changes
Oct 14, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DirectDepositEmailJobis not called anywhere–not in a periodic job or elsewhere in vets-api so it can be deleted along with any tests that reference it. @tpharrison saysVANotifyDdEmailJobreplaced it.Related issue(s)
Testing done
No errors in the console, specs pass. I am not familiar with this specific job, so please comment if you see issues with the code I've deleted.
Screenshots
Coverband report for prod that shows many lines in the job are not being run:
What areas of the site does it impact?
None, since it's not being used anymore.
Acceptance criteria