Update suffix concatenation to handle nil
values - form 10-7959f-1
#18351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the JSON erb mapping for form 10-7959f-1 so that the concatenation of suffix to lastname works even when suffix isn't provided. Previously, we would get an type error
no implicit conversion of nil into String
. By switching to usejoin()
rather than+
, nil values are handled gracefully.Related issue(s)
Testing done
Screenshots
What areas of the site does it impact?
This form only
Acceptance criteria
Requested Feedback
NA