Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update suffix concatenation to handle nil values - form 10-7959f-1 #18351

Merged

Conversation

michaelclement
Copy link
Contributor

@michaelclement michaelclement commented Sep 6, 2024

Summary

This PR updates the JSON erb mapping for form 10-7959f-1 so that the concatenation of suffix to lastname works even when suffix isn't provided. Previously, we would get an type error
no implicit conversion of nil into String. By switching to use join() rather than +, nil values are handled gracefully.

  • Fixes string concatenation for suffixes in JSON erb

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Nil suffix Suffix present
PDF Screenshot 2024-09-06 at 13 45 48 Screenshot 2024-09-06 at 13 45 40

What areas of the site does it impact?

This form only

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

NA

@michaelclement michaelclement marked this pull request as ready for review September 6, 2024 18:47
@michaelclement michaelclement requested review from a team as code owners September 6, 2024 18:47
@michaelclement michaelclement enabled auto-merge (squash) September 6, 2024 18:49
@michaelclement michaelclement merged commit 72b7aec into master Sep 6, 2024
28 of 33 checks passed
@michaelclement michaelclement deleted the fix-concatenation-of-suffix-to-lastname-json-erb branch September 6, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants