-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBX-88683] update 526 state logger with StatsD #18314
Conversation
state_log.each do |dp, ids| | ||
def state_as_counts | ||
@state_as_counts ||= {}.tap do |abbreviation| | ||
base_state.each do |dp, ids| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this was the variable name used before too, but what is dp
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm curious to look at the gauges on the dashboard. Good find!
Can you try merging in master to see if that fixes the test failures? |
2021bca
to
0f917bc
Compare
Summary
StatsD
gauges. this will unblock the desired state visualization.Related issue(s)
Testing done
What areas of the site does it impact?
526 state logging
Acceptance criteria