Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBX-88683] update 526 state logger with StatsD #18314

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

SamStuckey
Copy link
Contributor

@SamStuckey SamStuckey commented Sep 4, 2024

Summary

  • This work is behind a feature toggle (flipper): NO
  • Update the state logger to also use StatsD gauges. this will unblock the desired state visualization.
  • For now we are leaving the logs in place as well for full context, if needed.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Previously this just wrote logs, but Datadog mapping of a changing payload value is better handled with Gauges

What areas of the site does it impact?

526 state logging

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution (comming soon)
  • Documentation has been updated (see above)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature (n/a)

@va-vfs-bot va-vfs-bot temporarily deployed to dbx-88683/convert-526-state-log-to-gauge/main/main September 4, 2024 22:05 Inactive
state_log.each do |dp, ids|
def state_as_counts
@state_as_counts ||= {}.tap do |abbreviation|
base_state.each do |dp, ids|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this was the variable name used before too, but what is dp?

Copy link
Contributor

@tommasina-va tommasina-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm curious to look at the gauges on the dashboard. Good find!

@SamStuckey SamStuckey marked this pull request as ready for review September 5, 2024 14:59
@SamStuckey SamStuckey requested review from a team as code owners September 5, 2024 14:59
@SamStuckey SamStuckey added disability-experience To manage benefits disability claims experience. disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) labels Sep 5, 2024
@rjohnson2011
Copy link
Contributor

Can you try merging in master to see if that fixes the test failures?

@SamStuckey SamStuckey merged commit 4d2ca74 into master Sep 5, 2024
22 of 25 checks passed
@SamStuckey SamStuckey deleted the dbx-88683/convert-526-state-log-to-gauge branch September 5, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) disability-experience To manage benefits disability claims experience. require-backend-approval test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants