Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIMPLE_FORMS] feat: add logic to handle multiple attachments for 20-10207 #18308

Closed
wants to merge 8 commits into from
Closed

[SIMPLE_FORMS] feat: add logic to handle multiple attachments for 20-10207 #18308

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2bd3756
add logic to handle multiple attachments for 20-10207
pennja Sep 4, 2024
91903a7
refactor benefit intake client logic into its own class
pennja Sep 5, 2024
ea87c12
further refinement of BenefitsIntakeClient class
pennja Sep 5, 2024
004c168
reduce redundancy of PdfFiller logic
pennja Sep 5, 2024
43375c2
fix oopsy
pennja Sep 5, 2024
5f9586b
fixes to a couple of missed logic
pennja Sep 5, 2024
af535bf
updates in accordance with PR feedback
pennja Sep 5, 2024
6befb90
more small changes
pennja Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 14 additions & 129 deletions modules/simple_forms_api/app/controllers/simple_forms_api/v1/uploads_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,6 @@ class UploadsController < ApplicationController
before_action :load_user, if: :skip_authentication?
skip_after_action :set_csrf_header

FORM_NUMBER_MAP = {
'21-0966' => 'vba_21_0966',
'21-0972' => 'vba_21_0972',
'21-0845' => 'vba_21_0845',
'21-10210' => 'vba_21_10210',
'21-4138' => 'vba_21_4138',
'21-4142' => 'vba_21_4142',
'21P-0847' => 'vba_21p_0847',
'26-4555' => 'vba_26_4555',
'40-0247' => 'vba_40_0247',
'20-10206' => 'vba_20_10206',
'40-10007' => 'vba_40_10007',
'20-10207' => 'vba_20_10207'
}.freeze

UNAUTHENTICATED_FORMS = %w[40-0247 21-10210 21P-0847 40-10007].freeze

def submit
Expand All @@ -37,7 +22,8 @@ def submit
elsif form_is264555_and_should_use_lgy_api
handle264555
else
submit_form_to_benefits_intake
benefits_intake_client = SimpleFormsApi::BenefitsIntakeClient.new(@current_user, params)
benefits_intake_client.submit_form
end

clear_saved_form(params[:form_number])
Expand Down Expand Up @@ -71,10 +57,6 @@ def get_intents_to_file

private

def lighthouse_service
@lighthouse_service ||= BenefitsIntake::Service.new
end

def skip_authentication?
UNAUTHENTICATED_FORMS.include?(params[:form_number]) || UNAUTHENTICATED_FORMS.include?(params[:form_id])
end
Expand All @@ -92,7 +74,7 @@ def handle_210966_authenticated

if Flipper.enabled?(:simple_forms_email_confirmations)
SimpleFormsApi::ConfirmationEmail.new(
form_data: parsed_form_data, form_number: get_form_id, confirmation_number:, user: @current_user
form_data: parsed_form_data, form_number: fetch_form_id, confirmation_number:, user: @current_user
).send
end

Expand All @@ -118,105 +100,6 @@ def handle264555
{ json: { reference_number:, status: }, status: lgy_response.status }
end

def submit_form_to_benefits_intake
form_id = get_form_id
parsed_form_data = JSON.parse(params.to_json)
file_path, metadata, form = get_file_paths_and_metadata(parsed_form_data)

if Flipper.enabled?(:simple_forms_lighthouse_benefits_intake_service)
status, confirmation_number = upload_pdf(file_path, metadata, form)
else
status, confirmation_number = SimpleFormsApi::PdfUploader.new(file_path, metadata,
form).upload_to_benefits_intake(params)
end

form.track_user_identity(confirmation_number)

Rails.logger.info(
'Simple forms api - sent to benefits intake',
{ form_number: params[:form_number], status:, uuid: confirmation_number }
)

if status == 200 && Flipper.enabled?(:simple_forms_email_confirmations)
SimpleFormsApi::ConfirmationEmail.new(
form_data: parsed_form_data, form_number: form_id, confirmation_number:, user: @current_user
).send
end

{ json: get_json(confirmation_number || nil, form_id), status: }
end

def get_file_paths_and_metadata(parsed_form_data)
form_id = get_form_id
form = "SimpleFormsApi::#{form_id.titleize.gsub(' ', '')}".constantize.new(parsed_form_data)
# This path can come about if the user is authenticated and, for some reason, doesn't have a participant_id
if form_id == 'vba_21_0966' && params[:preparer_identification] == 'VETERAN' && @current_user
form = form.populate_veteran_data(@current_user)
end
filler = SimpleFormsApi::PdfFiller.new(form_number: form_id, form:)

file_path = if @current_user
filler.generate(@current_user.loa[:current])
else
filler.generate
end
metadata = SimpleFormsApiSubmission::MetadataValidator.validate(form.metadata,
zip_code_is_us_based: form.zip_code_is_us_based)

form.handle_attachments(file_path) if %w[vba_40_0247 vba_20_10207 vba_40_10007].include? form_id

[file_path, metadata, form]
end

def upload_pdf(file_path, metadata, form)
location, uuid = prepare_for_upload(form)
log_upload_details(location, uuid)
response = perform_pdf_upload(location, file_path, metadata)

[response.status, uuid]
end

def prepare_for_upload(form)
location, uuid = lighthouse_service.request_upload
stamp_pdf_with_uuid(form, uuid)
create_form_submission_attempt(uuid)

[location, uuid]
end

def stamp_pdf_with_uuid(form, uuid)
# Stamp uuid on 40-10007
pdf_stamper = SimpleFormsApi::PdfStamper.new(stamped_template_path: 'tmp/vba_40_10007-tmp.pdf', form:)
pdf_stamper.stamp_uuid(uuid)
end

def create_form_submission_attempt(uuid)
form_submission = create_form_submission(uuid)
FormSubmissionAttempt.create(form_submission:)
end

def create_form_submission(uuid)
FormSubmission.create(
form_type: params[:form_number],
benefits_intake_uuid: uuid,
form_data: params.to_json,
user_account: @current_user&.user_account
)
end

def log_upload_details(location, uuid)
Datadog::Tracing.active_trace&.set_tag('uuid', uuid)
Rails.logger.info('Simple forms api - preparing to upload PDF to benefits intake', { location:, uuid: })
end

def perform_pdf_upload(location, file_path, metadata)
lighthouse_service.perform_upload(
metadata: metadata.to_json,
document: file_path,
upload_url: location
)
end

def form_is264555_and_should_use_lgy_api
params[:form_number] == '26-4555' && icn
end
Expand All @@ -225,11 +108,11 @@ def icn
@current_user&.icn
end

def get_form_id
def fetch_form_id
form_number = params[:form_number]
raise 'missing form_number in params' unless form_number

FORM_NUMBER_MAP[form_number]
SimpleFormsApi::BenefitsIntakeClient::FORM_NUMBER_MAP[form_number]
end

def get_json(confirmation_number, form_id)
Expand Down Expand Up @@ -258,13 +141,15 @@ def prepare_params_for_benefits_intake_and_log_error(e)
end

def json_for210966(confirmation_number, expiration_date, existing_intents)
{ json: {
confirmation_number:,
expiration_date:,
compensation_intent: existing_intents['compensation'],
pension_intent: existing_intents['pension'],
survivor_intent: existing_intents['survivor']
} }
{
json: {
confirmation_number:,
expiration_date:,
compensation_intent: existing_intents['compensation'],
pension_intent: existing_intents['pension'],
survivor_intent: existing_intents['survivor']
}
}
end
end
end
Expand Down
8 changes: 4 additions & 4 deletions modules/simple_forms_api/app/models/simple_forms_api/vba_20_10207.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ def metadata
end

def zip_code_is_us_based
@data.dig('veteran_mailing_address',
'country') == 'USA' || @data.dig('non_veteran_mailing_address', 'country') == 'USA'
@data.dig('veteran_mailing_address', 'country') == 'USA' ||
@data.dig('non_veteran_mailing_address', 'country') == 'USA'
end

def handle_attachments(file_path)
Expand Down Expand Up @@ -135,8 +135,6 @@ def track_user_identity(confirmation_number)
living_situations:, other_reasons:)
end

private

def get_attachments
attachments = []

Expand Down Expand Up @@ -164,6 +162,8 @@ def get_attachments
attachments
end

private

def veteran_ssn
[
data.dig('veteran_id', 'ssn')&.[](0..2),
Expand Down
Loading
Loading