Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve MethodLength Rubocop Disables - Part 1 #18300

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Resolve MethodLength Rubocop Disables - Part 1 #18300

merged 7 commits into from
Sep 6, 2024

Conversation

stevenjcumming
Copy link
Contributor

Summary

Some inline rubocop disables are unnecessary, so they should be refactored

# rubocop:disable Metrics/MethodLength

Issues

Acceptance Criteria

  • Rubocop is enabled for MethodLength and rubocop passes

@stevenjcumming stevenjcumming self-assigned this Sep 4, 2024
@stevenjcumming stevenjcumming requested review from a team as code owners September 4, 2024 16:51
github-actions[bot]
github-actions bot reviewed Sep 4, 2024
View reviewed changes
app/services/form1010cg/auditor.rb Show resolved Hide resolved
app/services/form1010cg/auditor.rb Show resolved Hide resolved
app/services/form1010cg/auditor.rb Outdated Show resolved Hide resolved
app/services/form1010cg/auditor.rb Outdated Show resolved Hide resolved
app/services/form1010cg/auditor.rb Outdated Show resolved Hide resolved
app/sidekiq/copay_notifications/mcp_notification_email_job.rb Show resolved Hide resolved
app/sidekiq/copay_notifications/mcp_notification_email_job.rb Show resolved Hide resolved
app/sidekiq/cypress_viewport_updater/cypress_config_js_file.rb Show resolved Hide resolved
app/sidekiq/cypress_viewport_updater/cypress_config_js_file.rb Show resolved Hide resolved
app/sidekiq/cypress_viewport_updater/cypress_config_js_file.rb Show resolved Hide resolved
@stevenjcumming stevenjcumming marked this pull request as draft September 4, 2024 20:16
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-resolve-method-length-disable-1/main/main September 4, 2024 21:06 Inactive
coope93
coope93 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@coope93 coope93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this 👍

@stevenjcumming stevenjcumming marked this pull request as ready for review September 5, 2024 15:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

Backend-review-group approval confirmed.

@stevenjcumming stevenjcumming merged commit 135d65c into master Sep 6, 2024
26 of 29 checks passed
@stevenjcumming stevenjcumming deleted the sjc-resolve-method-length-disable-1 branch September 6, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

@coope93 coope93 coope93 approved these changes

Assignees

@stevenjcumming stevenjcumming

Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenjcumming @coope93 @rjohnson2011 @va-vfs-bot