Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

91997: Fix checkbox mapping #18297

Merged
merged 1 commit into from
Sep 4, 2024
Merged

91997: Fix checkbox mapping #18297

merged 1 commit into from
Sep 4, 2024

Conversation

balexandr
Copy link
Contributor

When OHI or Medicare aren't present, we don't need to be checking boxes "No" in those sections (will need to update backend pdf mapping to change this).

Current state: questions in the Medicare and OHI sections are being filled in even when the user answers no.
Expected state: if the user answers no to Medicare or other health insurance, the associated questions should not be filled in.

The issue is because our JSON file we have Booleans set but when it comes through from the FE it converts them to a string. So to appease both ew just check both to be safe.

Summary

  • Update the 10-7959C form mapping to check for 'true' or true

Related issue(s)

Testing done

  • Manuel
  • Rspec

Screenshots

Before:
Screenshot 2024-09-04 at 11 51 20 AM

After:
Screenshot 2024-09-04 at 11 51 45 AM

@balexandr balexandr merged commit 65e8b95 into master Sep 4, 2024
32 of 34 checks passed
@balexandr balexandr deleted the 91997-fix-107959c-mapping branch September 4, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants