Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-39328] Add totals rows to monthly submission report #18290

Merged
merged 14 commits into from
Sep 10, 2024

Conversation

tycol7
Copy link
Contributor

@tycol7 tycol7 commented Sep 3, 2024

Summary

Add Totals row to each monthly status counts table

Related issue(s)

API-39328

Testing done

  • New code is covered by unit tests

Screenshots

totals-rows

What areas of the site does it impact?

Monthly status report emails

Acceptance criteria

  • I added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

N/A

@tycol7 tycol7 added the claimsApi modules/claims_api label Sep 3, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-totals-rows-to-monthly-report/main/main September 3, 2024 23:25 Inactive
@tycol7 tycol7 force-pushed the tdc/add-totals-rows-to-monthly-report branch from 5484c06 to ce77d49 Compare September 4, 2024 22:10
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-totals-rows-to-monthly-report/main/main September 4, 2024 22:28 Inactive
@tycol7 tycol7 force-pushed the tdc/add-totals-rows-to-monthly-report branch from 931bab5 to 6c0e439 Compare September 4, 2024 23:53
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-totals-rows-to-monthly-report/main/main September 5, 2024 00:11 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-totals-rows-to-monthly-report/main/main September 5, 2024 00:35 Inactive
Copy link

github-actions bot commented Sep 5, 2024

1 Warning
⚠️ This PR changes 240 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/claims_api/app/sidekiq/claims_api/report_monthly_submissions.rb (+40/-13)

  • modules/claims_api/app/views/claims_api/_ews_status_table.html.erb (+22/-22)

  • modules/claims_api/app/views/claims_api/_itf_status_table.html.erb (+3/-3)

  • modules/claims_api/app/views/claims_api/_monthly_claims_status_table.html.erb (+2/-2)

  • modules/claims_api/app/views/claims_api/_poa_status_table.html.erb (+22/-22)

  • modules/claims_api/app/views/claims_api/submission_report_mailer/submission_report.html.erb (+3/-0)

  • modules/claims_api/spec/sidekiq/report_monthly_submissions_spec.rb (+64/-10)

  • spec/mailers/previews/claims_api_submission_report_mailer_preview.rb (+8/-4)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-totals-rows-to-monthly-report/main/main September 5, 2024 01:10 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-totals-rows-to-monthly-report/main/main September 5, 2024 15:48 Inactive
@tycol7 tycol7 marked this pull request as ready for review September 5, 2024 16:22
@tycol7 tycol7 requested a review from a team as a code owner September 5, 2024 16:22
@tycol7 tycol7 merged commit de42a43 into master Sep 10, 2024
21 checks passed
@tycol7 tycol7 deleted the tdc/add-totals-rows-to-monthly-report branch September 10, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants