Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove va_online_scheduling_appointment_details_redesign feature toggle #18281

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Remove va_online_scheduling_appointment_details_redesign feature toggle #18281

merged 1 commit into from
Sep 4, 2024

Conversation

JunTaoLuo
Copy link
Contributor

Summary

  • Removing obsolete feature toggle since the feature has been fully released.
  • Appointments (VAOS) team

Related issue(s)

Testing done

  • Ensured existing test suites pass

What areas of the site does it impact?

Appointments (VAOS)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@JunTaoLuo JunTaoLuo requested review from a team as code owners September 3, 2024 19:09
vbahinwillit
vbahinwillit approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@vbahinwillit vbahinwillit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Backend-review-group approval confirmed.

@JunTaoLuo JunTaoLuo merged commit 4c841e2 into master Sep 4, 2024
33 of 35 checks passed
@JunTaoLuo JunTaoLuo deleted the jtluo/remove-va_online_scheduling_appointment_details_redesign branch September 4, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

@vbahinwillit vbahinwillit vbahinwillit approved these changes

Assignees
No one assigned
Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JunTaoLuo @vbahinwillit @rjohnson2011 @va-vfs-bot