Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-37992-remove-vbms-from-healthchecks #18244

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Aug 28, 2024

Reminder

Notify Leeroy Jenkles in case they need to update anything on their side for monitoring dependencies. 

Summary

  • Removes EVSS healthchecks
  • Refactors metadata_spec

Related issue(s)

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

modified:   modules/claims_api/spec/requests/metadata_spec.rb
modified:   modules/claims_api/config/initializers/okcomputer.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod changed the title Api 37992 remove vbms from healthchecks API-37992-remove-vbms-from-healthchecks Aug 28, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to API-37992-remove-vbms-from-healthchecks/main/main August 28, 2024 22:37 Inactive
@stiehlrod stiehlrod requested a review from a team August 28, 2024 22:41
@stiehlrod stiehlrod self-assigned this Aug 28, 2024
@stiehlrod stiehlrod marked this pull request as ready for review August 28, 2024 22:42
@stiehlrod stiehlrod requested a review from a team as a code owner August 28, 2024 22:42
@stiehlrod stiehlrod requested a review from a team September 3, 2024 14:45
@stiehlrod stiehlrod requested a review from a team September 3, 2024 16:42
@stiehlrod stiehlrod enabled auto-merge (squash) September 3, 2024 18:52
@stiehlrod stiehlrod merged commit 27bcb31 into master Sep 3, 2024
22 of 23 checks passed
@stiehlrod stiehlrod deleted the API-37992-remove-vbms-from-healthchecks branch September 3, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants