Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize IvcChampva & MebApi Request Specs #18239

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Reorganize IvcChampva & MebApi Request Specs #18239

merged 5 commits into from
Sep 5, 2024

Conversation

stevenjcumming
Copy link
Contributor

Summary

  • Files were renamed to follow convention (detailed at the bottom)
  • Top-level example groups were renamed to follow convention

Related issue(s)

Testing done

  • No new tests

Acceptance criteria

  • The tests pass
  • request specs files are named and organized based on established convention
  • request specs example group names are named based on established convention

@stevenjcumming stevenjcumming requested review from a team as code owners August 28, 2024 19:26
@stevenjcumming
Copy link
Contributor Author

@balexandr would you mind reviewing this PR?

@stevenjcumming stevenjcumming self-assigned this Aug 29, 2024
rjohnson2011
rjohnson2011 previously approved these changes Aug 29, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Backend-review-group approval confirmed.

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-ivc-meb-request-spec-reorg/main/main September 3, 2024 14:00 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-ivc-meb-request-spec-reorg/main/main September 3, 2024 23:55 Inactive
@stevenjcumming stevenjcumming merged commit 42e97a2 into master Sep 5, 2024
24 of 25 checks passed
@stevenjcumming stevenjcumming deleted the sjc-ivc-meb-request-spec-reorg branch September 5, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

Assignees

@stevenjcumming stevenjcumming

Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenjcumming @rjohnson2011 @va-vfs-bot